build Cppcheck with Boost for improved ValueFlow performance

neutrinolabs · Sep 9, 2023 · 13a6be0 · 13a6be0
1 parent 1818c9f
commit 13a6be0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -180,7 +180,7 @@ jobs:
           cache-name: cache-cppcheck
         with:
           path: ~/cppcheck.local
-          key: ${{ steps.os.outputs.image }}-build-${{ env.cache-name }}-${{ env.CPPCHECK_VER }}
+          key: ${{ steps.os.outputs.image }}-build-${{ env.cache-name }}-${{ env.CPPCHECK_VER }}-boost
       - run: sudo scripts/install_cppcheck_dependencies_with_apt.sh $CPPCHECK_VER
       - run: ./bootstrap
       - run: ./configure

diff --git a/scripts/install_cppcheck.sh b/scripts/install_cppcheck.sh
@@ -130,7 +130,8 @@ fi
             ;;
         2.8 | 2.9 | 2.1*)
             # Cppcheck 2.8 removed the dependency on z3
-            make_args="FILESDIR=$FILESDIR PREFIX=$FILESDIR"
+            # Cppcheck 2.8 added optional support for utilizing Boost
+            make_args="FILESDIR=$FILESDIR PREFIX=$FILESDIR CPPFLAGS=-DHAVE_BOOST"
             ;;
         2.*)
             make_args="FILESDIR=$FILESDIR PREFIX=$FILESDIR USE_Z3=yes"

diff --git a/scripts/install_cppcheck_dependencies_with_apt.sh b/scripts/install_cppcheck_dependencies_with_apt.sh
@@ -24,6 +24,8 @@ case "$CPPCHECK_VER" in
             ;;
         2.8 | 2.9 | 2.1*)
             # Cppcheck 2.8 removed the dependency on z3
+            # Cppcheck 2.8 added optional support for utilizing Boost
+            PACKAGES="$PACKAGES libboost-container-dev"
             ;;
         2.*)
             PACKAGES="$PACKAGES libz3-dev z3"