Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce -DHAVE_BOOST to cppcheck builds #3312

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

matt335672
Copy link
Member

A regression introduced in cppcheck 2.15.0 has been fixed in 2.16.0 - see @firewave's comment in #3291

A regression introduced in cppcheck 2.15.0 has been fixed in 2.16.0
@matt335672 matt335672 merged commit b40ace3 into neutrinolabs:devel Nov 15, 2024
14 checks passed
@firewave
Copy link
Contributor

This did not rebuild the binary since your forgot to adjust the cache key.

@matt335672
Copy link
Member Author

That's a good point - thanks.

The binary did get rebuilt for my branch, as I used a different branch name:-

https://github.com/matt335672/xrdp/actions/runs/11858253988/job/33048444115

So I'm pretty sure the modification above is fine.

I've just deleted the old cache at https://github.com/neutrinolabs/xrdp/actions/caches (see https://stackoverflow.com/questions/63521430), so I think we're all OK now, at least as far as this repository is concerned. Users with forks may also need to do this for branches they are working on.

@matt335672 matt335672 deleted the cppcheck_add_have_boost branch November 27, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants