Remove/replace time calls #3328
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt335672
force-pushed
the
fix_time_calls
branch
3 times, most recently
from
4bf6595 to
32ba1d0
Compare
This is not year 2038 compliant on systems with 32-bit integers. The call can be replaced with the standard C time() call. On POSIX systems, time_t is guaranteed to be an integer type.
This is currently unused in xrdp
The function as specified used gettimeofday() which is susceptible to manual time changes, and is obsoleted in POSIX.1-2008. The replacement uses clock_gettime(CLOCK_MONOTONIC, ) which is not susceptible to manual time changes (at least on Linux) and cannot run backwards. Also, on systems with 32-bit integers, the value returned by this function wraps around every 49.7 days. To cope with a wraparound in a way compliant with the C standard, this value needs to return an unsigned integer type rather than a signed integer type.
matt335672
force-pushed
the
fix_time_calls
branch
from
32ba1d0 to
1f79eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: No longer draft.
This does not need to be back-ported to v0.10. It's mostly a tidy-up looking to the future.
This PR removes
g_time1()andg_time2()and replacesg_time3()with the more descriptively namedg_get_elapsed_ms()Each function is addressed in a separate commit in this PR.
g_time1()is not year 2038 compliant on systems with 32-bit integers. It can be trivially replaced withtime()which is a standard C library function, so that is done here.g_time2()is no longer used.g_time3()is a little more complex:-gettimeofday()call it uses is obsoleted in POSIX.1-2008. Here we useclock_gettime(CLOCK_MONOTONIC, )