Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: really removes tmp dir after cli run #761

Merged
merged 1 commit into from
Nov 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/neutrond/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ func NewRootCmd() (*cobra.Command, params.EncodingConfig) {
// create a temporary application for use in constructing query + tx commands
initAppOptions := viper.New()
tempDir := tempDir()
// cleanup temp dir after we are done with the tempApp, so we don't leave behind a
// new temporary directory for every invocation. See https://github.com/CosmWasm/wasmd/issues/2017
defer os.RemoveAll(tempDir)
initAppOptions.Set(flags.FlagHome, tempDir)
tempApplication := app.New(
log.NewNopLogger(),
Expand Down Expand Up @@ -139,7 +142,6 @@ func tempDir() string {
if err != nil {
dir = app.DefaultNodeHome
}
defer os.RemoveAll(dir)

return dir
}
Expand Down
Loading