Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup pre-commit #225

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Setup pre-commit #225

merged 1 commit into from
Oct 15, 2024

Conversation

ktactac-ornl
Copy link
Contributor

@ktactac-ornl ktactac-ornl commented Oct 15, 2024 •
edited
Loading

Adds configuration file for pre-commit and runs the checks. Several files are modified as a result.

Additionally, this repository is added to pre-commit.ci

7490: [Story] setup pre-commit

@ktactac-ornl ktactac-ornl changed the title Initial setup and fixes Setup pre-commit Oct 15, 2024
@ktactac-ornl ktactac-ornl marked this pull request as ready for review October 15, 2024 15:22
@KedoKudo KedoKudo self-requested a review October 15, 2024 15:27
@KedoKudo KedoKudo self-assigned this Oct 15, 2024
KedoKudo
KedoKudo approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@KedoKudo KedoKudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, as we discussed offline, the pre-commit for notebooks will be addressed at a later time when we can verify each notebook on analysis

@KedoKudo KedoKudo merged commit ea6f99d into next Oct 15, 2024
6 checks passed
@KedoKudo KedoKudo deleted the ewm7490-pre_commit-setup branch October 15, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KedoKudo KedoKudo KedoKudo approved these changes

Assignees

@KedoKudo KedoKudo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktactac-ornl @KedoKudo