Skip to content

Commit

Permalink
fix: implement review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
holyspectral committed Jul 9, 2024
1 parent 871b80b commit c00a681
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 24 deletions.
8 changes: 0 additions & 8 deletions charts/core/templates/controller-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@ spec:
command: ["/usr/local/bin/upgrader", "create-upgrader-job" ]
imagePullPolicy: {{ .Values.controller.certupgrader.imagePullPolicy }}
env:
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: OVERRIDE_CHECKSUM
value: {{ dict "image" (include "neuvector.controller.image" .) "internal" .Values.internal "certupgrader" .Values.controller.certupgrader | toJson | sha256sum }}
{{- with .Values.controller.certupgrader.env }}
Expand Down Expand Up @@ -127,10 +123,6 @@ spec:
initialDelaySeconds: 5
periodSeconds: 5
env:
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: CLUSTER_JOIN_ADDR
value: neuvector-svc-controller.{{ .Release.Namespace }}
- name: CLUSTER_ADVERTISED_ADDR
Expand Down
4 changes: 0 additions & 4 deletions charts/core/templates/enforcer-daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,6 @@ spec:
{{ toYaml .Values.resources | indent 12 }}
{{- end }}
env:
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: CLUSTER_JOIN_ADDR
value: neuvector-svc-controller.{{ .Release.Namespace }}
- name: CLUSTER_ADVERTISED_ADDR
Expand Down
4 changes: 0 additions & 4 deletions charts/core/templates/registry-adapter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@ spec:
{{- end }}
{{- end }}
env:
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: CLUSTER_JOIN_ADDR
value: neuvector-svc-controller.{{ .Release.Namespace }}
- name: HARBOR_SERVER_PROTO
Expand Down
4 changes: 0 additions & 4 deletions charts/core/templates/scanner-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,6 @@ spec:
{{- end }}
imagePullPolicy: Always
env:
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: CLUSTER_JOIN_ADDR
value: neuvector-svc-controller.{{ .Release.Namespace }}
{{- if .Values.cve.scanner.dockerPath }}
Expand Down
4 changes: 0 additions & 4 deletions charts/core/templates/upgrader-cronjob.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,6 @@ spec:
- /usr/local/bin/upgrader
- upgrader-job
env:
- name: POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
{{- with .Values.controller.certupgrader.env }}
{{- toYaml . | nindent 14 }}
{{- end }}
Expand Down

0 comments on commit c00a681

Please sign in to comment.