Add functionality to specify loadbalancerip for federation multi-cluster services #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reespozzi
changed the title
|
After merging other PR, there are some conflicts now. Can you resolve them? |
|
@becitsthere Resolved those and changes look the same again now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time committing here, happy to accept suggested improvements, testing changes, or anything else! Thanks
This PR attempts to add functionality to specify a static loadBalancerIP for the services required to be exposed by Multi-Cluster management, i.e
controller.federation.managedsvcandcontroller.federation.mastersvc.I've ran the test suite which passes, assuming the tests are correctly written 😁