Add probes on manager #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make manager probes optional - Add related documentation. - Fix probes always disabled when cert is auto generated.
- Use uppercase for scheme. - Make manager probe scheme use ssl option.
NeuronAddict
force-pushed
the
manager/add-probes
branch
from
674f5e6 to
62d6834
Compare
|
I don't find any endpoint like /health on manager, I use the home page (because many urls need a token) but an endpoint without a body that validate the backend connection will be more efficient. |
|
Tested on OCP, work since 21d. |
|
LGTM |
mjnagel
referenced
this pull request
in defenseunicorns/uds-core
Sep 13, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cgr.dev/du-uds-defenseunicorns/neuvector-updater-fips](https://images.chainguard.dev/directory/image/neuvector-fips/overview) ([source](https://redirect.github.com/chainguard-images/images-private/tree/HEAD/images/neuvector-fips)) | minor | `8.9.1-dev` -> `8.10.0-dev` | | [core](https://neuvector.com) ([source](https://redirect.github.com/neuvector/neuvector-helm)) | patch | `2.7.8` -> `2.7.9` | | [crd](https://neuvector.com) | patch | `2.7.8` -> `2.7.9` | | [monitor](https://neuvector.com) | patch | `2.7.8` -> `2.7.9` | --- ### Release Notes <details> <summary>neuvector/neuvector-helm (core)</summary> ### [`v2.7.9`](https://redirect.github.com/neuvector/neuvector-helm/releases/tag/2.7.9) [Compare Source](https://redirect.github.com/neuvector/neuvector-helm/compare/2.7.8...2.7.9) #### What's Changed - NVSHAS-9276 do not log jwt token by [@​holyspectral](https://redirect.github.com/holyspectral) in [https://github.com/neuvector/neuvector-helm/pull/421](https://redirect.github.com/neuvector/neuvector-helm/pull/421) - added edge support in schema json for openshift routes by [@​vtrenton](https://redirect.github.com/vtrenton) in [https://github.com/neuvector/neuvector-helm/pull/420](https://redirect.github.com/neuvector/neuvector-helm/pull/420) - Add probes on manager by [@​NeuronAddict](https://redirect.github.com/NeuronAddict) in [https://github.com/neuvector/neuvector-helm/pull/342](https://redirect.github.com/neuvector/neuvector-helm/pull/342) - bug: Remove duplicate volumeMounts keys from registry-adapter deployment by [@​sleepy](https://redirect.github.com/sleepy) in [https://github.com/neuvector/neuvector-helm/pull/397](https://redirect.github.com/neuvector/neuvector-helm/pull/397) - fix: volumeMounts for both internl and SSL by [@​holyspectral](https://redirect.github.com/holyspectral) in [https://github.com/neuvector/neuvector-helm/pull/423](https://redirect.github.com/neuvector/neuvector-helm/pull/423) - Bump version up for helm 2.7.9 release by [@​holyspectral](https://redirect.github.com/holyspectral) in [https://github.com/neuvector/neuvector-helm/pull/436](https://redirect.github.com/neuvector/neuvector-helm/pull/436) #### New Contributors - [@​vtrenton](https://redirect.github.com/vtrenton) made their first contribution in [https://github.com/neuvector/neuvector-helm/pull/420](https://redirect.github.com/neuvector/neuvector-helm/pull/420) - [@​sleepy](https://redirect.github.com/sleepy) made their first contribution in [https://github.com/neuvector/neuvector-helm/pull/397](https://redirect.github.com/neuvector/neuvector-helm/pull/397) **Full Changelog**: neuvector/neuvector-helm@2.7.8...2.7.9 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Micah Nagel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the manager is redeployed, it take a long time before it can take traffic.
The new manager container is marked ready (because no readiness is configured) but it can't forward requests correctly and the interface became unstable.
This PR add probes on manager :