Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NVSHAS-9382 allow providing TLS certificates #427

Merged

Conversation

holyspectral
Copy link
Contributor

Allow users to provide TLS certificates in helm charts. When both user-specified certificate and autoGenerate are enabled, user-specified certificate will take precedence.

Allow users to provide TLS certificates in helm charts.
@holyspectral
Copy link
Contributor Author

There are two parts of logic. Take manager for example:

  • Secret creation
    • As long as autoGenerateCert is true or certificate is provided in charts, the secret will be created.
    • The certificate provided in charts will be used by default.
  • Which secret to use
    • If .Values.manager.certificate.secret is provided (cert-manager use case), it will use the certificate provided by the secret.
    • If not, the secret created above will be used.

@selvamt94 selvamt94 merged commit b53dee1 into neuvector:pre-5.4 Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants