Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NVSHAS-9382 remove lookup for aws-addon #428

Merged
merged 25 commits into from
Aug 28, 2024

Conversation

holyspectral
Copy link
Contributor

@holyspectral holyspectral commented Aug 28, 2024

Also sync with pre-5.4 branch

$ git diff origin/pre-5.4 
diff --git a/charts/core/templates/_helpers.tpl b/charts/core/templates/_helpers.tpl
index 8a598d3..f8f5388 100644
--- a/charts/core/templates/_helpers.tpl
+++ b/charts/core/templates/_helpers.tpl
@@ -35,17 +35,9 @@ Create chart name and version as used by the chart label.
 Lookup secret.
 */}}
 {{- define "neuvector.secrets.lookup" -}}
-{{- $value := "" -}}
-{{- $secretData := (lookup "v1" "Secret" .namespace .secret).data  -}}
-{{- if and $secretData (hasKey $secretData .key) -}}
-  {{- $value = index $secretData .key -}}
-{{- else if .defaultValue -}}
-  {{- $value = .defaultValue | toString | b64enc -}}
-{{- end -}}
-{{- if $value -}}
+{{- $value := .defaultValue | toString | b64enc -}}
 {{- printf "%s" $value -}}
 {{- end -}}
-{{- end -}}
 
 {{- define "neuvector.controller.image" -}}
 {{- if .Values.global.azure.enabled }}

holyspectral and others added 25 commits August 1, 2024 19:17
In updater logs, JWT token would be printed unintentionally.
This PR makes it skip bearer token from command line output.
…tput-jwt-token

NVSHAS-9276 do not log jwt token
- Make manager probes optional
- Add related documentation.
- Fix probes always disabled when cert is auto generated.
- Use uppercase for scheme.
- Make manager probe scheme use ssl option.
1. New role and rolebinding for job creation and cert upgrader.
2. A new cronjob to run internal cert rotation regularly.
3. New options to enable cert generation and cert rotation.
Fix an issue where cert-upgrader pod created by cronjob has no effect
Allow users to provide TLS certificates in helm charts.
…in-charts

feat: NVSHAS-9382 allow providing TLS certificates
WARNING: Do not merge this to main tree as this is specifically for
aws-addon.
@selvamt94 selvamt94 merged commit 87356c9 into neuvector:aws-addon Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants