Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Artifexum spray chance to disintegrate #1044

Merged
merged 10 commits into from
Mar 29, 2024

Conversation

GreaseMonk
Copy link
Contributor

@GreaseMonk GreaseMonk commented Feb 21, 2024

About the PR

As it goes, when you spray artifexum, a liquid of the artifacts, over other artifacts, it will activate.
However, there is the occasional chance that it will have enough power to create a portal strong enough to swoop the artifact back to it's planar world where it came from, however it also brought something back....

Spraying artifacts will now have 5-15% chance to destroy the artifact and spawn a artifact golem.
Credit to @dvir001 for coming up with the idea, im just the hands that surf the keyboard
Credit to @MatthewBadger for artwork and audio

Untitled.video.-.Made.with.Clipchamp.4.mp4

Why / Balance

Spray to get points made artifact research useless, no point in doing it if you can just put 50 on a rock and spray it.

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

@Cheackraze
Copy link
Member

this is a clever solution, i hadnt thought of this yet. I like it, adds the missing risk/reward thats needed to the spray system.

@GreaseMonk
Copy link
Contributor Author

Waiting for @dvir001 for some sprites for artifact golem

@dvir001
Copy link
Contributor

dvir001 commented Feb 22, 2024

Thinking about using something like this
https://tgstation13.org/wiki/Golem

Copy link
Contributor

github-actions bot commented Mar 7, 2024

RSI Diff Bot; head commit abed20c merging into d080953
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Effects/creampie_64.rsi

State Old New Status
creampie_grimforged Added

Resources/Textures/_NF/Mobs/Aliens/grim_forged.rsi

State Old New Status
dead Added
flash Added
move Added
off Added

Edit: diff updated after abed20c

@GreaseMonk GreaseMonk added Status: Needs Review This PR is awaiting reviews and removed Status: DO NOT MERGE labels Mar 24, 2024
@GreaseMonk GreaseMonk marked this pull request as ready for review March 24, 2024 12:22
@GreaseMonk
Copy link
Contributor Author

As of now, this PR is ready for review, i could use some good looks to see where this PR can improve

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Mar 25, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Mar 25, 2024
@dvir001
Copy link
Contributor

dvir001 commented Mar 25, 2024

Is this ready or you still making changes?

@GreaseMonk
Copy link
Contributor Author

GreaseMonk commented Mar 26, 2024

Checkraze had concerns that this would be too much of a nerf and wants more player feedback after you made changes to artifexum before merging this.

It is ready for review.

@dvir001
Copy link
Contributor

dvir001 commented Mar 26, 2024

Checkraze had concerns that this would be too much of a nerf and wants more player feedback after you made changes to artifexum before merging this.

It is ready for review.

You can use the magnets scan code to locate arti next to arti in range of 3 meters and only then have this % active

This will only effect multi spray then while making it no risk to none abushers of this issue.

If possible have this scan done when it's doing the activation to not scan none stop.

@Cheackraze Cheackraze merged commit 0af9b8c into new-frontiers-14:master Mar 29, 2024
15 checks passed
@GreaseMonk GreaseMonk deleted the play-spray branch March 30, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants