Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feb 2024 Upstream Merge #1060

Merged
merged 1,305 commits into from
Mar 4, 2024
Merged

Feb 2024 Upstream Merge #1060

merged 1,305 commits into from
Mar 4, 2024

Conversation

Cheackraze
Copy link
Member

About the PR

Catches us up to upstream. WIP. Merge conflicts worked through, likely doesnt build.

Why / Balance

keeps us up to date

Technical details

lots

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Merges upstream to 2/26. See adjacant tab for more info.

PJBot and others added 30 commits February 16, 2024 18:43
…… (#25097)

Adds atmospherics access to the fire fighting door remote. Feels like an oversight for the atmos door remote to not have atmos access.

Co-authored-by: Plykiya <[email protected]>
- The dummy control of 2px size has annoyed me for almost 5 years.
- Why is it in the top-right.
- Why is the server address not labelled.
* Allow t-ray to penetrate carpets and puddles

* handle edge cases
* Initial commit

* Moved params to sound

* Removed type tag

* Removed null check

* Forced default
* added books to roles

* First pass

* removed yaml to split pull requests into resprite first, then giving the books to assistants

* new science
* LockVisualizer

* Fix state

* Clean some code

* Make it component, fix tests fail

* Fix for StateUnlocked

Now it is possible to manually set the unlocked state and it will work!

* Optimize LockVisualizer, add check for unlocked state

* No todo I guess
* Add test for two chemistry issues

1. rounding issue with reaction processing when making chloral hydrate
2. reliable assert trip due to the ValidateSolution() heat capacity issue.

* Fix FixedPoint2 arithmetic

Fix internal floating point arithmetic in places where it could be avoided.

Fix incorrect rounding mode used in other places (it should always floor, like regular int arithmetic).

I had to add an explicit epsilon value for float -> FixedPoint2 because something like 1.05 is actually like 1.04999 and that'd cause it to be rounded down to 1.04.

This fixes reaction reagent processing in cases where the reagent inputs can't cleanly divide. Previously, when making 30u chloral hydrate by adding the chlorine in 10u increments you'd end up with 0.04 chlorine left over. This was caused by division in the reaction code rounding up in some cases. Changing division here to always round down fixes it.

* Attempt to fix heat capacity precision assert issues.

Fixes #22126

First, we just increase the tolerance of the assert. It was way too low.

Second, actually put a cap on float drift from one-off _heatCapacity changes.

* Fix float -> FixedPoint2 epsilon for negative number, fix tests.

* Fix DamageableTest

* Oh yeah I need to call CleanReturnAsync
* Allow webp in lobby background files

* Make lobby art webp images

Reduces folder from 10 MB to 2.5 MB without only slight quality loss.

* Update PutLobbyScreensHere.txt
* add

* replace image with webp version

waiting on #25184
* Porting & implementation

* Fix two stupid errors

* Human not humans

* fix audio path

* Fix test fails & update cooldown

* Work on reviews & test fail

* Rework nymph organ system.

* Make the nymph organs nospawn.

* IsDeadIC
Make seeds from clipped plants inherit the decreased health from parents.
Also require one growth stage before clipping.
* nymphs now don't get deleted together with the body of the diona

* moved nymph system to server
* Fix: Grenades don't make trigger sound

* transform instead of trycomp transform

---------

Co-authored-by: Plykiya <[email protected]>
* Save round information into the replay

* Add round end text too

* This is way better

* Get actual job

* oop

* OK THERE

* Fake line endings to make life easier

* I was told this yaml is legal

* I just realised this will make my life easier

* REVIEWS BABY IM A PROGRAMMER MOMMY

* Live pjb reaction

* Live pjb reaction 2

* Reviews 2

* Dont need this

* Please no more have mercy on my soul

* Oh frick
Adds a massban flag to the admin flags used on ss14 to ban large amounts of players rom a .tsv file

Co-authored-by: Geekyhobo <[email protected]>
I could've sworn I corrected this before committing but guess not ???
* added evidence markers

* box tweak

* fixed a spelling mistake

* new sprites, tweaked yml too
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Feb 29, 2024
# Conflicts:
#	Content.Shared/Preferences/HumanoidCharacterProfile.cs
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Feb 29, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Mar 1, 2024
@Cheackraze Cheackraze merged commit 9fadd0c into master Mar 4, 2024
12 of 14 checks passed
FrontierATC added a commit that referenced this pull request Mar 4, 2024
@GreaseMonk GreaseMonk deleted the feb-2024-upstream-merge branch March 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Docs Improvements or additions to documentation FTL Sprites Status: Needs Review This PR is awaiting reviews UI YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.