Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New vends #110

Closed
wants to merge 83 commits into from
Closed

New vends #110

wants to merge 83 commits into from

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jul 29, 2023

About the PR

  • Moved few files that needed to be under _NF folders to correct locations, few textures, few yml and few ftl.
  • Added a new machine called the CuddlyCritterVend with fun stuff in it.
  • Added the "Jester Plushie", could be bought after machine emag.
  • Added new items flag called "MarketPrice" to help set prices to some items that should keep a shop price as labeled without looking into the static or machine multi.
  • Used the flag on all food items to make them lower while they still sell for less, added a lot more items for food machines (Most 3 items are now 30).
  • Added 2 Eyepatchs for cargo pirate crate

@dvir001 dvir001 marked this pull request as ready for review July 30, 2023 12:27
@Cheackraze
Copy link
Member

i kind of disagree with the food pricing change and the massive increase to food vendors. it turns the chef/cook gameplay into meaningless and worthless play. With food being worth its nutrition value, at least chefs can make money through the game market if they cook a bunch, and I may even buff the value of frontier's custom Flavorol ingredient still as well. Right now cakes sell for 250 a piece around flat price. of course to the depot more etc., but that goes a long way in 'baking' being worth it if you can still bake 2-3 dozen cakes and even if players don't buy, you can turn a profit etc.

@Cheackraze
Copy link
Member

the rest of it is great work though, if you split it we can discuss that change in a different PR and I would merge the other vending machine stuff and we can discuss the hard set price changes separate too.

@dvir001
Copy link
Contributor Author

dvir001 commented Jul 31, 2023

i kind of disagree with the food pricing change and the massive increase to food vendors. it turns the chef/cook gameplay into meaningless and worthless play. With food being worth its nutrition value, at least chefs can make money through the game market if they cook a bunch, and I may even buff the value of frontier's custom Flavorol ingredient still as well. Right now cakes sell for 250 a piece around flat price. of course to the depot more etc., but that goes a long way in 'baking' being worth it if you can still bake 2-3 dozen cakes and even if players don't buy, you can turn a profit etc.

I can up the food costs closer to what they were, or back to what they were.
right now, the prices on that PR are either more logical or a bit more than the high sell price if you try to sell them.
The amounts of items can be lower again to around 5~ instead of 3 if it's fine with you, I was trying to go with the "Vending machine has 300 items IRL" on them.

The hard price was used for items that logically speaking has no major price jumps with market changes (Food and toys in this case) and to help with predictable price for the vend, also some items like a plastic fork and fortune cockle that has no place costing 200... or even 20..

@dvir001
Copy link
Contributor Author

dvir001 commented Aug 2, 2023

Removed some changes.

@dvir001 dvir001 closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants