Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gazpacho - Atmospherics / Salvage Ship #1100

Closed
wants to merge 18 commits into from

Conversation

stranth
Copy link

@stranth stranth commented Mar 9, 2024

About the PR

Added the II Gazpacho, a small sized Atmospherics/Mining ship. This ship seeks to add to the lack of atmos related vessles in the Expeditionary Lodge.

Why / Balance

After noticing the lack of Atmospherics related expedition vessels, and after some testing, we have decided to bring more atmospherics to the Frontier. The Gazpacho comes equipped with gas chambers for Air and Mixed gas add an additional means of income for those that want to use their Atmospherics knowledge more on the frontier. The inspiration for the aesthetic of this ship was that dwarves and industry go hand in hand, therefore we went with the mining walls. Note the booze dispenser in medical bay for added dorf flavour. You too could sip cogchamp while sitting in mobile Jerry can!

Media

POV Views
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
GazpachoEntrance

GazpachoEVA

GazpachoBridge

GazpachoEngineering

GazpachoPlatform

Gazpachmos

Disclaimer1
Disclaimer2

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • 2024-03-08 add: Expedition Lodge Atmos/Salvage ship "II Gazpacho"
    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
  • 2024-03-09 Fix: Update Gazpacho to be more compliant with mapping guidelines & review.
  • 2024-03-09 Change: Restructured Commons area & Engineering to fit new power scheme.
  • 2024-03-09 Change: Replaced SUPERPACMAN Generators with the "Supper Matter Engine".
  • 2024-03-09 Change: Replaced Mining Wall with the Reinforced Wall.
  • 2024-03-09 Change: Removed the beloved C.R.A.B.TM
  • 2024-03-09 Change: Restructured Starboard thruster railings to make sense. The One Glass Tile is now gone.
  • 2024-03-09 Change: Docking ports are no longer the cool plasma glass ports. : (
  • 2024-03-09 Change: Updated the Operation Manual to reflect the changes to the Engine Room.
  • 2024-03-09 Change: Industrial Ore Processor is now Ore Processor.
    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
  • 2024-03-09 Fix: Reduce amount of Radiation Collectors to increase Plasma depletion rate. Expected Fuel Lifetime: 17 minutes/Plasma tank at 1013kPa@20C. Depletion rate DOES increase with Power Generation. Depletion rate can be reduced by adding more radiation collectors.
  • 2024-03-09 Change: Add Mining Wall back to certain exterior walls. Kept Reinforced wall around Engineering for Crew safety.
  • 2024-03-09 Change: Moved Operation Manual to Engineering
  • 2024-03-09 Add: Added a radiation treatment kit into Engineering for moments of "negligent operation".
    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
  • 2024-03-09 Change: Moved the radiation shutters in Engineering up one tile
  • 2024-03-09 Fix: Added a 2nd substation to reduce aneurysms caused by constant power flickering.
  • 2024-03-09 Add: Added a radiation closet in Engineering
  • 2024-03-09 Change: Replaced Gas Dispenser (Engineering) with just two Plasma Tank (Filled).
    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
  • 2024-03-09 Added: An aneurysm
    ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
  • 2024-03-09 Removed: The aneurysm I gained diagnosing the power net
  • 2024-03-09 Change: Replaced substations with wallmount substations. One in Engineering and one in the Commons.
  • 2024-03-09 Added: An additional Substation on the Ship Platform. ( ihatepowerihatepowerihatepower )

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Mar 9, 2024
Resources/Maps/_NF/Shuttles/gazpacho.yml Outdated Show resolved Hide resolved
Resources/Maps/_NF/Shuttles/gazpacho.yml Outdated Show resolved Hide resolved
Resources/Maps/_NF/Shuttles/gazpacho.yml Outdated Show resolved Hide resolved
Resources/Maps/_NF/Shuttles/gazpacho.yml Outdated Show resolved Hide resolved
Resources/Maps/_NF/Shuttles/gazpacho.yml Outdated Show resolved Hide resolved
Resources/Maps/_NF/Shuttles/gazpacho.yml Outdated Show resolved Hide resolved
Updated the Gazpacho to conform to review input & mapping guidelines.
Fix: Reduce amount of Radiation Collectors to increase Plasma depletion rate. Expected Fuel Lifetime: 17 minutes/Plasma tank at 1013kPa@20C. Depletion rate DOES increase with Power Generation. Depletion rate can be reduced by adding more radiation collectors.
Change: Add Mining Wall back to certain exterior walls. Kept Reinforced wall around Engineering for Crew safety.
Change: Moved Operation Manual to Engineering
Add: Added a radiation treatment kit into Engineering for moments of "negligent operation".
Commit: I dont think I actually added the file in the last commit. This is just to be certain......
@stranth stranth requested a review from dvir001 March 9, 2024 22:17
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Mar 9, 2024
Change: Moved the radiation shutters up one tile.
Fix: Added a 2nd substation to reduce future aneurysms caused by the constant power flickering
Change: Changed substation and PowerNet to NO LONGER FLICKER. Moved 2nd substation to a wallmount in commons.  Added a 3rd wallmount substation in Atmospherics. THE POWER GRID IS STABLE. This is a temporary fix until Pow3r is fixed. Because of the workaround I needed to do I am assuming it might be something to do with MV to LV conversion or the output of Substations.
Change: Moved Plasma Tanks and some materials into Engineering Bay
Change - Increased price from 50000 to 67255 to account for ability of craft in its intended operation.
Change - Train Lattice in extraction area is now Lattice to better blend with lattices that may be added by operators.
- Added file supposedly added from previous commit to compare
- Updated file in local repository so this time it is actually a new file. Diagnosis: Too absorbed in making Gas PRs.
Why is this here??? Huh... skub...
@Cheackraze
Copy link
Member

i think that giving out free busted RTGs is going to be a problem. This ship should come with normal pacman generators to power it. You can leave the room and the collector, but it should be up to the spaceman to obtain their radiation source if they want free-ish power

@MasterReef
Copy link

0/10 No Gazpacho. A tomato soup served ice cold.

@stranth
Copy link
Author

stranth commented Mar 28, 2024

i think that giving out free busted RTGs is going to be a problem. This ship should come with normal pacman generators to power it. You can leave the room and the collector, but it should be up to the spaceman to obtain their radiation source if they want free-ish power

Doesnt this directly contradict with the "Expedition Vessels must have a High Power generator though? Which as it stands would qualify only the AME in this context. The fuel needed for the Rad collectors lasts a calculated 18 minutes in its current config and if the crew isnt filling and finding canisters then they're dead in the water. Would love more context on this. ALSO, Mining Walls bad??? ( I noticed the Menace has them )

@stranth
Copy link
Author

stranth commented Mar 28, 2024

0/10 No Gazpacho. A tomato soup served ice cold.

D E S P A I R

@MagnusCrowe
Copy link
Contributor

It doesn't look like anything has been done to address the comments Checkraze or Dvir left. Please address those issues, then I'll review.

@MagnusCrowe MagnusCrowe added the Status: Awaiting Changes This PR has changes that need to be made before merging label Apr 21, 2024
Removed: Paramedic Job slot
Added: Engineer Job slot
Removed: Map from general shuttles folder
@github-actions github-actions bot added the YML label May 13, 2024
Removed: Damaged RTG & Rad collector
Removed: Medical bed
Added: AME
Added: Bed
@github-actions github-actions bot removed the YML label May 13, 2024
Changed: fixed map path
@dvir001
Copy link
Contributor

dvir001 commented May 17, 2024

Mind adding a guide book for the ship?

image

Please dont leave notes on ships, were moving to guides to allow forks to translate data.
Also this is not how you use the Changelog as this should be used in game!

@dvir001
Copy link
Contributor

dvir001 commented Jun 20, 2024

Leaving this PR closed till an update, when ready again you can ping us on the discord to either reopen this PR, reopen it yourself or you can just open a new PR.

In general, all you need to do here is just either make a guidebook after the new guidebook PR
#1534

Or move the existing notes into entity like we did here https://github.com/new-frontiers-14/frontier-station-14/pull/1524/files#diff-dc488a0085a6caa306084f270bad1a88eccea82a9167d576ecde6a96cd4f0794
On the frontier note. (This still allows other forks to edit the text as needed to remove frontier mention or to change the content)

@dvir001 dvir001 closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Awaiting Changes This PR has changes that need to be made before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants