Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Money Tree Expedition Reward, and Pears. #124

Merged
merged 12 commits into from Aug 3, 2023
Merged

Money Tree Expedition Reward, and Pears. #124

merged 12 commits into from Aug 3, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 31, 2023

About the PR

Adds money trees to the expedition reward pool, they mimic gatfruit in stats, and pay out 3 single dollar bills. Not the miracle they sound like... also snuck in a little kitchenfarms tribute, as they were the inspiration for this plant, and a hilarious fun time i will remember forever.

also adds pears, as I added pears while walking my friend through it as he wants to learn to contribute as well, its a bit of a bloaty addition, they are just apples with the teensiest buff, but getting them in would impress and astound my friend a ton, we chose pears as they are an inside joke within our discord.
Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: Added Money Trees
  • add: Added Money Trees to Exped Rewards
  • add: Added Pears

@Cheackraze
Copy link
Member

some of your rsi sprite images are of the incorrect size, and need to be multiple of 32x32 it appears. The RSI Validator and the Yaml Linter will have more info for you.

@ghost
Copy link
Author

ghost commented Aug 1, 2023

@Cheackraze newest commits added Money Tree 1000 seeds which drop 3 stacks of 1k, currently commented out and not accessible other than spawn menu, commented out because im not sure how you want the standard trees to be balanced.

they currently steal stats from gatfruit, but are able to be changed with botany mutations, the money prototype cant acquire the plant glow thing or anything, but the speed of production could be minorly changed. this can be disabled by giving the seed the immutable component. but even with the most perfect of botany mutations, it still only drops ones, and is essentially a joke item. not sure if thats your vision for it or not.

its incredibly easy to change the tree to drop stacks of 1, 10, 100 etc etc for all the predefined spawnable money prototypes. up to a million 💰 💰

let me know how you want it balanced and ill do so! thanks for considering it in the first place!

Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, ill test locally probably tonight or tomorrow and get it in very soon!

@Cheackraze Cheackraze merged commit 59fb809 into new-frontiers-14:master Aug 3, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant