Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mission Shuttle - A Religious Ship #126

Merged
merged 11 commits into from
Aug 13, 2023

Conversation

kennedytcooper
Copy link
Contributor

About the PR

Adds the Mission a religion and cleaning shuttle featuring a chapel, crematorium, and full janitorial services.

Media

Screenshot from 2023-07-30 11-56-21

Changelog

🆑

  • add: the mission ship, a religious & cleaning shuttle

@kennedytcooper
Copy link
Contributor Author

this one is ready for hopefully final review

@kennedytcooper kennedytcooper changed the title Mission shuttle Mission Shuttle - A Religious Ship Jul 31, 2023
@Cheackraze
Copy link
Member

i went to review this one to try to add it soon but I think you made a mistake when you were copying files. You have 2x the same file in both places, but it looks like you meant to have the ship file itself there.

@kennedytcooper
Copy link
Contributor Author

Oops! Try it again at your convenience, it's fixed now

@Cheackraze
Copy link
Member

I like the overal design and the compact feel, but there are just a few minor things that would make it even better
image
the big glass structure/window is a great idea and we can keep that aesthetic and view, but it makes the whole shuttle vulnerable to pirate laser fire, so I suggest replaceing the areas marked in green circles with shuttle walls.
Angled walls don't block vision properly either, and when used like where you have them marked in blue makes the view look bad, so try to put a few solid walls here to actually block vision, even if you have to make that wall 'thicker' by doing so.

@kennedytcooper
Copy link
Contributor Author

ready fore review again

@Cheackraze Cheackraze merged commit afd5460 into new-frontiers-14:master Aug 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants