Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better discord notifications #127

Merged

Conversation

OCOtheOmega
Copy link
Contributor

About the PR

Notifications about the start of a round have been added, this is useful as the rounds in the frontier are very long, also notifications from the galactic bank have been made in the form of embed messages.

Also if i start talk about discord, here mine - Gados#1923

Media
изображение
Better use separeted channels for round notifications and bank leaderboard.
Reminder: NEVER PUT WEBHOOK URL IN GIT REPOSITORY!

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: Round notification!
  • tweak: Make bank notifications embed!

@Kesiath
Copy link
Contributor

Kesiath commented Jul 31, 2023

Can you add a ping for the New Round Notification role? 1135611365332111420 is the role ID, I'll be adding it to the selectable roles soon

@OCOtheOmega
Copy link
Contributor Author

Its better to be written directly to config.toml, read reminder, some information must remain confidential.
But if you don't mind, I can add it directly to the ccvars.

@Cheackraze
Copy link
Member

yea our existing webhooks i have in our server config.toml files to keep them private. the repo stays clean of any of that stuff.

Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but going to wait to merge until I can replace my server config files and get our discord webhooks set up appropriately, likely later this evening or tomorrow

just prevents the discord payload from being sent to the void...

Also in the future it is possible to make a better leaderboard, e.g. top of the week, top of the month, etc.
@Cheackraze
Copy link
Member

this is still all good but as of now I plan on doing server maintenance this sunday/monday to merge this and a few other prep things like the discord bots and channels being reworked a touch, thanks for your patience and bare with us

@Cheackraze Cheackraze merged commit d1ba595 into new-frontiers-14:master Aug 7, 2023
11 checks passed
@OCOtheOmega OCOtheOmega deleted the Discord-integration-update branch August 7, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants