Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add n2 gas tanks #132

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Conversation

Graugr
Copy link
Contributor

@Graugr Graugr commented Aug 1, 2023

About the PR

added n2 emergency gas tank and variations
added n2 tanks to tank dispencer

Media

[x] The PR is completely finished and I don't need help to finish it.
[x] I carefully reviewed all my changes and did not find any bugs in them.
[x] I ran a local server with my changes and tested everything.
[x] I've added a screenshot/video of the in-game PR demo, or this PR doesn't require it.

Changelog

🆑 Graugr

  • add: N2 emergency tank
  • add: extended N2 emergency tank
  • add: double extended N2 emergency tank
  • tweak: Tank dispencer assortment changed
  • add: N2 emergency tank
  • add: extended N2 emergency tank
  • add: double extended N2 emergency tank
  • add: O2 emergency tank
  • add: extended O2 emergency tank
  • add: double extended O2 emergency tank
    29900-157de-30237285-m750x740

@sTiKyt
Copy link
Contributor

sTiKyt commented Aug 2, 2023

Would be nice to sort them a bit, so similar tanks with different content are next to each other

But that's just visuals

You can change listing order by simply moving entries around in the file where you add/remove inventory

Same way first 2 tanks are

(Extended oxygen > Extended nitrogen)
(Emergency oxygen > Emergency nitrogen)
etc.

Also, it would make sense if they had different price, because they have different capacity. But if you don't want, you could keep prices like that and I could update them later

@Graugr
Copy link
Contributor Author

Graugr commented Aug 2, 2023

Would be nice to sort them a bit, so similar tanks with different content are next to each other

But that's just visuals

You can change listing order by simply moving entries around in the file where you add/remove inventory

Same way first 2 tanks are

(Extended oxygen > Extended nitrogen) (Emergency oxygen > Emergency nitrogen) etc.

Also, it would make sense if they had different price, because they have different capacity. But if you don't want, you could keep prices like that and I could update them later

it's sorted, regular-emergency, oxygen-nitrogen.
different prices do not make sense, all cylinders are made using the same technology, only the amount of material and gas inside the cylinders changes. im checked sale price/ its 13-14 bucks for any of tank

@Cheackraze Cheackraze merged commit 0476d6e into new-frontiers-14:master Aug 3, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants