Auto rename ship faxes #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheackraze
reviewed
Aug 2, 2023
sTiKyt
reviewed
Aug 2, 2023
Resources/Prototypes/Entities/Structures/Machines/fax_machine.yml
Outdated
Show resolved
Hide resolved
# Conflicts: # Resources/Prototypes/_NF/Entities/Structures/machines.yml
Cheackraze
approved these changes
Aug 4, 2023
Samsterious
pushed a commit
to Samsterious/lagrange-station
that referenced
this pull request
Apr 26, 2024
This fixes a bug with the respawn button where it did not show the cooldown properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Add new faxes prototype -
"FaxMachineShip". This faxes will automatically sync their name with a ship name. They will even keep name synced if ship will be somehow renamed.Ship maps should be updated is separate PR, but that should be easy to do even in a text editor.
Implementation is a bit weird. All this complexity comes from the problem that ship spawns as stations, and stations rename grid with a delay... But this code should be robust. I hope.
Media
Changelog
🆑