Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVT Mid-tier Weapon #1417

Merged
merged 33 commits into from
Jul 8, 2024
Merged

Add SVT Mid-tier Weapon #1417

merged 33 commits into from
Jul 8, 2024

Conversation

VividPups
Copy link
Contributor

@VividPups VividPups commented May 25, 2024

About the PR

There aren't any mid-tier weapons in the game at all. with this weapon, it is a good balance between the Mosin, and the AK a semi auto 10 round starting gun, that can accept 30-rounders when they find it/make it as a little upgrade to it
the weapon is not in the vending machine because people will buy that instead of other weapons like the Mosin
it can be found in the shuttle gun (T2) and gun loot (as a common not a rare)

How to test

used both spawners and spawned them in

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

2 new recipes have been added to the ammofab (upstream), those recipes are found under _NF

Changelog

add the SVT

🆑

  • add: S.E.S.W.C has added a new weapon to the Shuttle gun
    -->

Copy link
Contributor

github-actions bot commented May 25, 2024

RSI Diff Bot; head commit bbb0797 merging into e508192
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Weapons/Ammunition/svt40.rsi

State Old New Status
base Added
mag-1 Added
practice Added
red Added
rubber Added
uranium Added

Resources/Textures/_NF/Objects/Weapons/Guns/Rifles/svt40.rsi

State Old New Status
base Added
bolt-open Added
equipped-BACKPACK Added
equipped-SUITSTORAGE Added
icon Added
inhand-left Added
inhand-right Added
mag-0 Added
wielded-inhand-left Added
wielded-inhand-right Added

Edit: diff updated after bbb0797

update
small updates
@VividPups
Copy link
Contributor Author

Ummmm im not sure why these errors are showing. there is no problem with any of the textures in game

so i can fix it
fix
pratice is more of an outlier now to look more like the tip of the bullet
@dvir001
Copy link
Contributor

dvir001 commented May 26, 2024

image

@VividPups
Copy link
Contributor Author

VividPups commented May 26, 2024

What's the problem? I see 1 that is Cap.. ig that could be the problem

image

Whats the problem?

VividPups and others added 3 commits May 26, 2024 16:56
IM NOT GOOD AT ENGLISHER
Mags where in the wrong place
@VividPups
Copy link
Contributor Author

image

Fix

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look, works alright. Biggest thing is that I don't know how this'd fit in with the other mid-tier suggestions (#1265, #1277), especially if they're all acceptable.

I think the sprites in particular could use a bit of work, and double check if you want your mags to be interchangeable with an AKMS.

@VividPups
Copy link
Contributor Author

Took a look, works alright. Biggest thing is that I don't know how this'd fit in with the other mid-tier suggestions (#1265, #1277), especially if they're all acceptable.

I think the sprites in particular could use a bit of work, and double check if you want your mags to be interchangeable with an AKMS.

Yes the SVT is post to be interchangeable with the AK

@VividPups
Copy link
Contributor Author

Ill fix the Shuttlegun stuff tomorrow

Shuttle update
ammo
updates to the yml again
@VividPups VividPups requested a review from whatston3 June 10, 2024 01:08
@github-actions github-actions bot added Status: Needs Review This PR is awaiting reviews Merge Conflict This PR has conflicts that prevent merging labels Jun 10, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@VividPups
Copy link
Contributor Author

Why r u like this

@VividPups VividPups closed this Jun 15, 2024
@VividPups VividPups reopened this Jun 16, 2024
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Jun 16, 2024
@VividPups
Copy link
Contributor Author

@whatston3 as of now, the only problem I am having is the SVT sprite files, they are not want to use 64 by 32 or 64 by 64 even with edits to the metaj son files. it could be something I change and add later when I Get more answers on how to fix it

@whatston3
Copy link
Contributor

@whatston3 as of now, the only problem I am having is the SVT sprite files, they are not want to use 64 by 32 or 64 by 64 even with edits to the metaj son files. it could be something I change and add later when I Get more answers on how to fix it

Interesting. Unsure off the top of my head how to fix that, would need to look into this.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Jun 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

AAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
@VividPups
Copy link
Contributor Author

Sprites were change @whatston3

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Jun 24, 2024
@VividPups
Copy link
Contributor Author

Oh SHIT nothing BROKE

@Cheackraze Cheackraze merged commit 0c93099 into new-frontiers-14:master Jul 8, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Jul 8, 2024
@VividPups VividPups deleted the SVT40 branch July 16, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants