Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YarrrDrobe #1502

Merged
merged 6 commits into from
Jun 14, 2024
Merged

YarrrDrobe #1502

merged 6 commits into from
Jun 14, 2024

Conversation

Salvantrix
Copy link
Contributor

@Salvantrix Salvantrix commented Jun 11, 2024

Adds the new pirate drobe vending machine for all your pirate wears n such.

About the PR

Why / Balance

Pirates need clothes too!

How to test

Open game, place Drobe, profit.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

image

Breaking changes

Changelog

Adds the YarrrDrobe

Adds the new pirate drobe vending machine for all your pirate wears n such.
AAAAAAAA
Copy link
Contributor

github-actions bot commented Jun 11, 2024

RSI Diff Bot; head commit 9a6da8e merging into 4586a34
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Machines/VendingMachines/yarrrdrobe.rsi

State Old New Status
broken Added
normal-unshaded Added
off Added
panel Added

Edit: diff updated after 9a6da8e

It should work as intended.
@Salvantrix
Copy link
Contributor Author

YML errors will clear once uplink and sprites are merged just FYI

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by pulling in the head of Pirate-Stuff locally. Looks great! Left a few questions & suggestions for your consideration, looking forward to seeing it in-game.

@Salvantrix
Copy link
Contributor Author

Tested by pulling in the head of Pirate-Stuff locally. Looks great! Left a few questions & suggestions for your consideration, looking forward to seeing it in-game.

Np! Also to answer pirates do have bank accounts I think? And with this change being a push to round start slots openings shouldn't be an issue

@Cheackraze Cheackraze merged commit 55c3507 into new-frontiers-14:master Jun 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants