Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laser Pistol #1527

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Jun 16, 2024

About the PR

Laser pistol with new visuals to replace retro laser pistols. Functionally identical (except fits in pockets), but looks better imo.

Why / Balance

I personally don't like the sprites for retro laser pistol, feel free to close this PR if you disagree

How to test

Spawn LibertyVend
Buy Laser pistol

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

none afaik

Changelog
🆑 erhardsteinhauer

  • tweak: Laser pistols have a new sprite, and take up a 1x2 rectangle in inventories.

Copy link
Contributor

github-actions bot commented Jun 16, 2024

RSI Diff Bot; head commit c5b1b72 merging into 16ada9e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Weapons/Guns/Battery/laser_pistol.rsi

State Old New Status
base Added
icon Added
inhand-left-0 Added
inhand-left-1 Added
inhand-left-2 Added
inhand-left-3 Added
inhand-left-unshaded Added
inhand-left Added
inhand-right-0 Added
inhand-right-1 Added
inhand-right-2 Added
inhand-right-3 Added
inhand-right-unshaded Added
inhand-right Added
mag-unshaded-0 Added
mag-unshaded-1 Added
mag-unshaded-2 Added
mag-unshaded-3 Added
mag-unshaded-4 Added

Edit: diff updated after c5b1b72

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chunky gun, flashy lights, I like the design a lot.

One thing: is this supposed to be a complete replacement? Found three sources otherwise:

  • ShuttleWeaponLaserGun still spawns the retro laser (weapon_cases_shuttle_gun.yml)
  • Merc NPC tier 3 medics can spawn one (npc_loot_mercenaries.yml)
  • CBURN units could spawn with them (in their pocket - once it comes out, it won't go back in - misc_startinggear.yml)

With respect to pocket loadout, seems strong, and a good backup option. Only thing I could see being an issue is carrying a ton of laser pistols to cheese expeditions (should they have airlocks without glass more often?). Don't really have any strong thoughts either way apart from that.

@ErhardSteinhauer
Copy link
Contributor Author

Only thing I could see being an issue is carrying a ton of laser pistols to cheese expeditions (should they have airlocks without glass more often?).

Players are already doing that with retro laser pistols. I don't believe that 2 additional pistols in their pockets will make a difference. I haven't changed inventory footprint of pistols.

One thing: is this supposed to be a complete replacement?

Not really, but might as well do it.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jun 16, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, love the new sprite, but I'd like a second opinion on balance.

@VividPups
Copy link
Contributor

VividPups commented Jun 16, 2024

Retro shouldn't be replaced completely but be a unique rare weapon instead. Since that guy is a reference gun

@ErhardSteinhauer
Copy link
Contributor Author

Nah, it should become a weapon for laser tag

@ErhardSteinhauer
Copy link
Contributor Author

It already looks like a knock off Star Track toy, might as well go all the way and turn it into practice laser pistol.

@VividPups
Copy link
Contributor

...that's the reference star trek

@ErhardSteinhauer
Copy link
Contributor Author

Can't even tell where is the dangerous end of that pistol.

@dvir001
Copy link
Contributor

dvir001 commented Jun 30, 2024

Should get this in before upstream merge honestly.

@whatston3 whatston3 merged commit 52cf8b8 into new-frontiers-14:master Jun 30, 2024
15 checks passed
FrontierATC added a commit that referenced this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants