Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microwave #1531

Merged
merged 6 commits into from
Jun 21, 2024
Merged

Microwave #1531

merged 6 commits into from
Jun 21, 2024

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jun 16, 2024

About the PR

Added the upstream Microwave and anti ID in microwave code.

Why / Balance

Make it impossible to microwave cards just to be able to hack into NFSD / SR Office.

How to test

Spawn microwave
Add card
MMMMM
Explode.

Media

N/A

Breaking changes

N/A

Changelog
N/A

Vermidia and others added 5 commits June 17, 2024 00:03
* THE syndie microwave

* Always burn to explode microwave when copying

* Make it so copying ids stop when the microwave is goign to explode

* Made explosion destroy the board and spit out the machine parts

* Move logic is MicrowaveSystem, make metal cooking use the same logic

* Fix passing the wrong malfunction time

* Shuttle cannot escape aggressive branding

* Always make it explode with an id

* Forgot to invert bool, move it after fry chance
Copy link
Contributor

github-actions bot commented Jun 16, 2024

RSI Diff Bot; head commit ade4031 merging into 16ada9e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Machines/microwave_syndie.rsi

State Old New Status
mw Added
mw0 Added
mw_running_unlit Added
mw_unlit Added
mwb Added
mwbloody0 Added
mwbloody1 Added
mwo Added

Edit: diff updated after ade4031

@MagnusCrowe
Copy link
Contributor

Syndicate microwave?

@dvir001
Copy link
Contributor Author

dvir001 commented Jun 17, 2024

Syndicate microwave?

Yes, from upstream
Its coming with the near update either way lamo

@whatston3 whatston3 self-assigned this Jun 17, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works alright. There seems to be a bug with the cook time reduction, haven't looked into why, but I think it's the capacitors being used - resulting cook multiplier should maybe be the product of a base value (which the syndicate microwave prototype sets) and the machine components used.

Microwave destruction works on both. I should add the microwave board to the mail table (and clean up the noSpawn values on all the paper).

Sad we can't have a matching red SMEG-ish fridge. Looking forward to buying a Bocadillo and being double-griefed because somebody forgot their ID in a ship console.

description: So advanced, it can cook donk-pockets in a mere 2.5 seconds!
components:
- type: Microwave
cookTimeMultiplier: 0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a complaint, but this doesn't seem to actually get applied on spawns, might be conflicting with the machine parts being used - should test if it works upstream.

@whatston3 whatston3 merged commit 235e359 into new-frontiers-14:master Jun 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants