Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Slowdown Thresholds For Hostile NPCs #1532

Closed
wants to merge 4 commits into from
Closed

Fixed Slowdown Thresholds For Hostile NPCs #1532

wants to merge 4 commits into from

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Jun 17, 2024 •
edited
Loading

About the PR

  • Corrected speedModifierThresholds for SlowOnDamage for expedition mobs.
  • Fixed ranged aberrant flesh enemies.
  • Buffed movement speed for aberrant flesh enemies.

Why / Balance

Fixes

How to test

  1. Spawn expedition specific mobs
  2. Attack them
  3. When mob's HP goes down to around 40% from max, mob should slowdown
  4. When mob's HP goes down to around 20%, mob should slowdown even more

Media

  • This PR does not require an ingame showcase

Breaking changes

None afaik

Changelog
🆑 erhardsteinhauer

  • fix: Fixed SlowOnDamage mechanic thresholds for expedition mobs.

@whatston3 whatston3 self-assigned this Jun 17, 2024
whatston3
whatston3 reviewed Jun 17, 2024
View reviewed changes
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense. Looking through the values, they seem consistent at 60%, 80%.

Spawned in a few monsters through the spawn command, seemed to behave sensibly. Flesh monsters are speedy.

One star AI's pretty beefy, damn. Wish the expedition enemies showed up in the spawn menu, but that's just a problem for me.

Haven't run through an actual expedition at time of writing, but I like the changes I see.

Resources/Prototypes/_NF/Entities/Mobs/NPCs/mob_hostile_expeditions_aberrant_flesh.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_NF/Entities/Mobs/NPCs/mob_hostile_expeditions_aberrant_flesh.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_NF/Entities/Mobs/NPCs/mob_hostile_expeditions_explorers.yml Show resolved Hide resolved
whatston3
whatston3 requested changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a small issue with the Clamp monster with this set of changes. Doesn't move at all after the HTN is removed, throws an exception in ThrowingSystem.TryThrow, can't be hit, but repeatedly throws batches of darts at the player. Seems like a bug, need to look into this.

Resources/Prototypes/_NF/Entities/Mobs/NPCs/mob_hostile_expeditions_aberrant_flesh.yml
Comment on lines -13 to -24
- type: HTN
rootTask:
task: SimpleHostileCompound
blackboard:
NavClimb: !type:Bool
true
NavInteract: !type:Bool
true
NavPry: !type:Bool
true
NavSmash: !type:Bool
true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For whatever reason, when this is removed, the Clamp enemy becomes an unhittable, stationary monster that can't be highlighted. Not quite sure why that is, need to look into this more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can only happen when you spawn Clamps through console command while not in aghost.

2024-06-19.07-46-04.mp4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to happen when you use spawner for aberrant flesh and doesn't seem to happen on expeditions (jumped on 2 expeds with aberrant flesh)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-06-19.08-04-00.mp4

Copy link
Contributor Author

@ErhardSteinhauer ErhardSteinhauer Jun 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-06-19.08-06-27.mp4

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jun 19, 2024
whatston3
whatston3 approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change to the Clamps are a nice touch. Testing through through the spawners works well, flesh enemies in expedition slow down as expected.

@ErhardSteinhauer ErhardSteinhauer mentioned this pull request Jun 20, 2024
Merged
2 tasks
@ErhardSteinhauer
Copy link
Contributor Author

Moving changes made in this PR to the #1548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whatston3 whatston3 whatston3 approved these changes

Assignees

@whatston3 whatston3

Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErhardSteinhauer @whatston3