Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail: Cleanup, Fixes, More SR Mail #1535

Merged

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Jun 17, 2024

About the PR

Cleans up mail papers (noSpawn set to true), adds more mail for the SR. Skub, SecurityDonuts, and SecurityNFSpaceLaw mail entries fixed.

Why / Balance

noSpawn was only commented out for testing - should've been removed when the PR went out of draft. Skub, Donuts, and SpaceLaw entries were broken. My fault, sloppy. SR could also use some more mail.

How to test

Spawn in, check spawn menu for "MailPaperNF". Nothing should show up.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None.

Changelog

🆑

  • tweak: Skub and a few security mail types have been fixed. Added a new SR and common mail type.

@dvir001 dvir001 self-requested a review June 19, 2024 19:19
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jun 19, 2024
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SecurityDonuts

Why no poisoned donuts?..

Repurposing: Sustenance

Big Sad

Anyways, tested, seems to be working fine.

@dvir001 dvir001 merged commit dc1370d into new-frontiers-14:master Jun 28, 2024
11 checks passed
FrontierATC added a commit that referenced this pull request Jun 28, 2024
@whatston3 whatston3 deleted the 2024-06-17-mail-clurger-cleanup branch July 2, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants