Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pen signing fix #1540

Merged

Conversation

TsjipTsjip
Copy link
Contributor

About the PR

Fixes a bug where the server would erroneously let people think they are, and I quote, A very important person. This was caused by pens still having the stamp component from the old signing system, component has now been removed and signing works as normal.

Why / Balance

Fixing bugs.

How to test

Spawn paper.
Spawn any stamp.
Stamp paper.
Click paper without alt, observe. You are not A very important person.

Changelog

🆑

  • fix: Left clicking a signed/stamped paper won't add a bogus signature onto it anymore.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle Map-POI Map - POI C# UI FTL Map-Outpost Map - Outpost Merge Conflict This PR has conflicts that prevent merging labels Jun 18, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added YML and removed Map-Shuttle Map - Shuttle Map-POI Map - POI UI FTL Map-Outpost Map - Outpost Merge Conflict This PR has conflicts that prevent merging labels Jun 18, 2024
@TsjipTsjip
Copy link
Contributor Author

Branch is no longer cooked. Have at ye, reviewers.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Alt+click to sign is still convenient, and no more accidental signing on left-click.

Good stuff.

@ErhardSteinhauer ErhardSteinhauer merged commit bf22b1b into new-frontiers-14:master Jun 19, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants