Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mats Crate #155

Merged
merged 5 commits into from
Aug 13, 2023
Merged

Mats Crate #155

merged 5 commits into from
Aug 13, 2023

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Aug 5, 2023

About the PR

A new crate for cargo,

1 sheet of glass, plastic, steel, plasma and plasteel.
Cost: 8400, based on the content of the crate.

This crate useful for people who want a bit of everything, but don't want to buy full crates.

@sTiKyt
Copy link
Contributor

sTiKyt commented Aug 6, 2023

Woudn't it bring back circuits production spam?

@dvir001
Copy link
Contributor Author

dvir001 commented Aug 6, 2023

Woudn't it bring back circuits production spam?

In what way? the price is balanced per prices right now, its 1/6 price of the crates it worth.

@potato1234x
Copy link
Contributor

yeah if people wanted to do that they could just buy the crates seperately

@Graugr
Copy link
Contributor

Graugr commented Aug 7, 2023

nope. its must cost at least 50k, someone can use it foi circuitboard spam. Noone neede 6 stacks of durathread

@dvir001
Copy link
Contributor Author

dvir001 commented Aug 7, 2023

nope. its must cost at least 50k, someone can use it foi circuitboard spam. Noone neede 6 stacks of durathread

15 pieces of glass, plastic, steel, plasma and plasteel, 10 pieces of cloth and 6 pieces of durathread.

When you see SheetName1 it means a single unit

@Cheackraze
Copy link
Member

so a half stack or less variety pack of materials? I was also confused at first at the intent behind this but that makes much more sense, but at least now I can consider it properly

@dvir001
Copy link
Contributor Author

dvir001 commented Aug 7, 2023

so a half stack or less variety pack of materials? I was also confused at first at the intent behind this but that makes much more sense, but at least now I can consider it properly

There is only 1 issue with this crate, the way the game handle the stacks will not make the items auto stack (It was removed from upstream since it was lagging the game)

So when you open it you have to combine the items back into 15 units or the crate wont lock itself with all the items, don't merge it yet I will either add a "15" entity or just make the crate cost 2 times more and have 2 times the items (to have full stack instead)

@dvir001
Copy link
Contributor Author

dvir001 commented Aug 8, 2023

Updated the content of it and the price.

@Cheackraze Cheackraze merged commit 41ac55d into new-frontiers-14:master Aug 13, 2023
11 checks passed
rbertoche pushed a commit to rbertoche/frontier-station-14 that referenced this pull request Aug 30, 2023
Cheackraze pushed a commit that referenced this pull request Jan 10, 2024
* PR 1

* fix an error with health bar overlay (#1292)

* Revert "Revert "Replace `ResourcePath` with `ResPath` (#15308)" (#155… (#15566)

* [1612] change ShowHealthBarsComponent's DamageContainer field to a list (#1662)

* fix build

* no crit entities from not updating

* cleanup

* namespace

* undu irrelevant changes

* undo icon change

* make health bar 1 px taller and icon 1 px shorter

* fix medibot

* fix comment

* don't show health bar ratio when in crit

* fix build

* put the crit bar back

* don't render healthbars for mobs that are in containers

* draw more boxes without the background sprite

* fine status icon for all bio mobs

* add wacky mandatory things

* attempt 2

* whoops wrong file

* cool, this works too

* move null check to top

* only 1 init

* security huds

* remove shader

* fix build after cleanup

* slight cleanup

* little more cleanup

* Remove clothing grant component system

* security HUD now shows a job icon on entities with a body

* remove sec stuff and do similar changes to split off PR + remove unused comp

* process comments

* don't return

* update to ComponentAddedOverlaySystemBase

* no cache

* colors and not rendering out of sight

* touch ups

* fix build & cleanup

* undo

* remove shader from icons

* process comments

* documentation

* fix licence

* validate prototype id

* just use args

* rename method and append in method

* type

* just fucken delete the command

* space

* undo

* remove

* don't use LocalPlayer

* re-add showhealthbars command, but working

* rename icon lists and conform health icon code to the others

* space

* undo

* update command

* oops

---------

Co-authored-by: Rane <[email protected]>
Co-authored-by: metalgearsloth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants