Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

McCargo (Update) #1614

Merged
merged 28 commits into from
Aug 7, 2024
Merged

McCargo (Update) #1614

merged 28 commits into from
Aug 7, 2024

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jul 5, 2024

About the PR

Updated the ships to new guidelines

Why / Balance

Improve the McCargo and McDelivery

How to test

mapinit / spawn from shipyard

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

image

image

Breaking changes

N/A

🆑 dvir01

  • tweak: Updated McCargo and the McDelivery
  • tweak: McCargo now comes with the McDrive Thru for food on the go.

@github-actions github-actions bot added the Map-Shuttle Map - Shuttle label Jul 5, 2024
@dvir001
Copy link
Contributor Author

dvir001 commented Jul 5, 2024

Draft since I need to add guidebook + new crate + price lookup

@github-actions github-actions bot added the No C# label Jul 5, 2024
@jimmy12or
Copy link
Contributor

but, what changes are being made?

@dvir001
Copy link
Contributor Author

dvir001 commented Jul 7, 2024

but, what changes are being made?

Im posting picture and full changelog when its done, this PR is mostly just to keep track of it.
Its on Draft.

@github-actions github-actions bot added Map-Dungeon Map - Dungeon Sprites labels Jul 16, 2024
Copy link
Contributor

github-actions bot commented Jul 16, 2024

RSI Diff Bot; head commit c081a49 merging into 2e7a1b7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:
Edit: diff updated after c081a49

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Jul 20, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Jul 20, 2024
@github-actions github-actions bot added Docs Improvements or additions to documentation FTL labels Aug 3, 2024
@dvir001 dvir001 marked this pull request as ready for review August 3, 2024 21:44
@dvir001
Copy link
Contributor Author

dvir001 commented Aug 3, 2024

It is done

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Aug 4, 2024
@MagnusCrowe
Copy link
Contributor

It takes 4 or 5 seconds for the ship to register as purchased for some reason...That can't be good.

Everything else is great, love the drive thru. Look into the spawn delay please.

image
Side note: We need to put the jerry cans in the fuel vend instead of the jugs of fuel. The are nice.

@dvir001
Copy link
Contributor Author

dvir001 commented Aug 5, 2024

It takes 4 or 5 seconds for the ship to register as purchased for some reason...That can't be good.

Everything else is great, love the drive thru. Look into the spawn delay please.
Side note: We need to put the jerry cans in the fuel vend instead of the jugs of fuel. They are nice.

I think the spawn issue might be related to storage containers, ill try to remove the empty 6 McBoxes and keep 2, same with big cig cartons since they have multi layers containers.

Also I need to still add a wall mount jukebox so ill need to edit it anyway

The jerry cans are in the fuel vender now btw.

@github-actions github-actions bot added C# and removed No C# labels Aug 6, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dvir001 dvir001 merged commit c0fcf8b into new-frontiers-14:master Aug 7, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Docs Improvements or additions to documentation FTL Map-Dungeon Map - Dungeon Map-Shuttle Map - Shuttle Sprites Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants