Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragonfly (Update) #1622

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Conversation

crystalHex
Copy link
Contributor

@crystalHex crystalHex commented Jul 6, 2024

About the PR

  • Fixed overlapping pipes

  • Internal 'shuttle walls' are now 'internal shuttle walls'

  • Fixed fuel jar not being in the controller on purchase

  • Removed mapped trash spawners and food

  • Removed bar

  • Replaced chemistry equipment with a rollerbed and paramedic's equipment

  • Re-decorated the lounge area

  • Re-decorated the salvage bay

  • Expanded cargo bay by moving table to lounge

  • Added spare conveyor belt assemblies

  • Added suit storages for all crew members

  • Added port and starboard lighting

  • Updated ship description

Why / Balance

Major shipyard rebalance + Dragonfly's atmos set-up broke after a merge

How to test

  1. Open lodge shipyard console.
  2. Purchase Dragonfly

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Fixed Dragonfly pipes, unpowered thrusters and interior walls.
  • tweak: Re-balanced Dragonfly, replaced chem wing with triage wing, removed food and bar, increased cargo space.

- Fixed overlapping pipes

- Internal 'shuttle walls' are now 'internal shuttle walls'

- Fixed fuel jar not being in the controller on purchase
@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Jul 6, 2024
@dvir001
Copy link
Contributor

dvir001 commented Jul 6, 2024

Picture?

@crystalHex
Copy link
Contributor Author

The front:
dragonfly-fore
The back:
dragonfly-aft

(Yes, I know the wires don't have to extend that far, that was just to make routing power to any front expansions easier)

@dvir001
Copy link
Contributor

dvir001 commented Jul 6, 2024

Keep in mind were removing all mapped food, mapped trash spawn and bars from most ships that are mining focus

With major edits to chem areas and medical area to only have medical bed and locker. this ship will get a major refactor later, or now if you can assist on it now please.

@crystalHex
Copy link
Contributor Author

Yeah I can probably do that next week, whenever I have time.

How extensive should the rework be?

@dvir001
Copy link
Contributor

dvir001 commented Jul 7, 2024

Yeah I can probably do that next week, whenever I have time.

How extensive should the rework be?

Look at the bulker PR
#1625

Were doing big balance changes to all ships, and stepping down the medical and food aspects of ships that don't have this function as the main ones (Isn't a medical / food ship)

In the case of this ship, the medical need a big remake to remove all machines except normal beds and one medical locker, no vending.

The full bar need to be a single freezer and microwave.

This isnt just a Dragonfly issue, we looking into making changes to all expo ships to split roles.

As a side note, all the machines I listed to remove are all found in expos, the goal is to allow people to still build the ships up but not to start with a all in one ship going into shift.

@dvir001
Copy link
Contributor

dvir001 commented Jul 10, 2024

Either way im ok with this as a pre extended PR edit

@dvir001 dvir001 requested a review from MagnusCrowe July 10, 2024 14:01
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jul 10, 2024
@crystalHex
Copy link
Contributor Author

Yeah I've started the rework, I've just got some irl issues to deal with first.

Hoping to get an initial re-design out this week.

- Removed mapped trash spawners and food

- Removed bar

- Replaced chemistry equipment with a rollerbed and paramedic's equipment

- Re-decorated the lounge area

- Re-decorated the salvage bay

- Expanded cargo bay by moving table to lounge

- Added spare conveyor belt assemblies

- Added suit storages for all crew members

- Added port and starboard lighting

- Updated ship description
@crystalHex
Copy link
Contributor Author

Nevermind, that didn't take as long as I feared.

I replaced the chem wing with a triage wing, removed mapped food and drinks, and re-organized the rest of the ship to increase cargo space.

Pictures:
dragonfly_bow_bright
dragonfly_bow_dark
dragonfly_stern_bright
dragonfly_stern_dark

@crystalHex
Copy link
Contributor Author

Will try to re-fit the Dove before end of week as well.

@crystalHex crystalHex changed the title Minor Dragonfly fixes Dragonfly (Update) Jul 11, 2024
@MagnusCrowe
Copy link
Contributor

image
not sure if this is an issue with the ship itself or something else...can you look into this and provide a picture of it working if possible?

@dvir001
Copy link
Contributor

dvir001 commented Jul 14, 2024

image

Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine.

@ErhardSteinhauer ErhardSteinhauer merged commit e8077b6 into new-frontiers-14:master Jul 19, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants