-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smuggling posters are now random and NFSD gets rewarded for getting prints of posters and dead drops #1667
Smuggling posters are now random and NFSD gets rewarded for getting prints of posters and dead drops #1667
Conversation
This reverts commit a008ba6.
…posters to the dead drop system
… and made the wait time faster for posters
…drop location is now said by NFSD Outpost
…sos and functioned the code for giving rewards
If possible I would love if it could alert pirates as well. |
Hey that would be a great idea, I am going to also probably make it so posters which are waiting for others to finish also reset their timer, because after some thinking I realized that posters would activate one after another if they were left untouched for far too long. As for the scanner I don't know since I don't know how to make a different sprite, I could just grab the forensic one and change its colors to red or something, or I could just make it so pirates get rewards if they dock. |
Definitely a neat idea! |
…osters that are active nearby
I think that in the end it's better not to implement it even if it's a cool idea because it would make accidentally smuggling for pirates really easy, and as long as that's a rule I don't think that adding rewards for pirates to check out dead drops is that good of an idea. |
If you speed it up again this is going to force security again to only fight SMUGGG for the full shift and doing nothing else like it was before. Also this should be added in some guidebook entry there isn't anything in game to tell you about the scan posters. |
Alright, I can probably get a guidebook entry in the forensics part, also what happened before? I didn't play back then. |
Telling the NFSD the location of the pod is defeating the purpouse of smuggling imo. With that you just have a race with the nfsd who gets there first. Everything else looks cool. |
They get notified 15 minutes after, it's meant to be there so people don't collect smuggling papers without visiting each location first because if not NFSD would've got to it. |
…-station-14 into smuggling-buff
RSI Diff Bot; head commit bcca650 merging into 0dd59b7 Resources/Textures/_NF/Objects/Devices/cartridge.rsi
Resources/Textures/_NF/Objects/Devices/forensic_scanner.rsi
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled in the changes, happy with the state of this. Would prefer a second set of eyes, but I do think it's alright.
Fixed remaining issues with printed vector precision, smuggling rewards should be marginally increased, pirates and NFSD should be getting messages (somewhat unreliably).
You are amazing! <3 The only thing left right now is to add the changes to Changelog in the comment above, no? Or is it not necessary at this point? Tell me what to do and I'll try to finish it off so this can be pulled fully. |
Gave the changelog an attempt - I think it's brief but descriptive enough. Feel free to make changes as you'd like. Testing it for bugs and getting your thoughts would be great. Config's a bit all over the place to get shorter delays, but most of it can be set through server-side CVARs (run I do think it's alright, but it's worth taking another look with fresher eyes. |
A few small changes:
Again, I think we'll have to see how this plays out, but again, works well under test. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…ier-station-14 into smuggling-buff
…-station-14 into smuggling-buff
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…-station-14 into smuggling-buff
Smuggling activity detected in your sector. |
About the PR
The PR changes several things about the smuggling posters and their mechanics:
Why / Balance
Discord idea thread: https://discord.com/channels/1123826877245694004/1260704805282910321
Currently the dead drop system or "smuggling" is not worth doing for newer players, a lot of the profitability from them comes from the fact whether you know EXACTLY which posters to search on each of the main locations and whether you get lucky enough to be on the timer.
To be exact the bullet point reasons are:
How to test
To test the systems this is what I did:
Media
Breaking changes
Changelog
🆑