Shuttle clean up follow up

[ErhardSteinhauer]

About the PR

PR will be in draft until changes made to the shuttles are tested.
Following yml-edits to the files were made:

• Removed job spawners.
• Removed trash spawners.
• Removed kitchen related machines (primarily microwaves) from non-food trucks.
• Removed food.
• Replaced filled weapon safes with empty ones.
• Removed Chemical machines and supplies from non-medical shuttles.
• Removed medical items from non-medical shuttles: removed medkits, filled cabinets are replaced with empty ones, vendomats replaced either with cabinets or machine frames.

Why / Balance

Clean up, push towards narrower shuttle specialization.

How to test

1. Load shuttles from the list

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Possible everything

Changelog
🆑 erhardsteinhauer

• remove: Removed food items and machines from non-food shuttles.
• remove: Removed medical/chemistry related items and machines from non-medical shuttles.

[arimah]

Re Stellaris: That's a service ship with an integrated kitchen. The idea is that it can serve simpler meals and refreshments alongside whatever performance is being put on. Removing its microwave and ChefVend leaves it with a crippled, non-functional kitchen. The ship should either be reworked not to include a kitchen at all, or be allowed to keep its kitchen. If the kitchen is removed, the ship will likely see even less use as one of its selling points is negated.

[ErhardSteinhauer]

Re Stellaris: That's a service ship with an integrated kitchen. The idea is that it can serve simpler meals and refreshments alongside whatever performance is being put on. Removing its microwave and ChefVend leaves it with a crippled, non-functional kitchen. The ship should either be reworked not to include a kitchen at all, or be allowed to keep its kitchen. If the kitchen is removed, the ship will likely see even less use as one of its selling points is negated.

irc the original PR, the shuttle was supposed to be a theatre. and the PR was submitted before the guidelines were a thing (I think), hence the kitchen.

[ErhardSteinhauer]

Hm. Perhaps Stellaris should be delisted until someone reworks it?

[arimah]

the shuttle was supposed to be a theatre

I mean... theatres in real life also sell food. That's where the profits are!

[dvir001]

the shuttle was supposed to be a theatre

I mean... theatres in real life also sell food. That's where the profits are!

Alot of them do catering or outside service and don't actually hire kitchen stuff.

[whatston3]

I mean... theatres in real life also sell food. That's where the profits are!

What if there was a specialized "junk food prep kit" you got for theatre concessions instead of ye olde stocked pantry?

Okay, you can serve food, but it's a pack of C&Ds, DIY popcorn and a large soda.

[dustylens]

"A medium-sized shuttle, with a large public area equipped with a stage with camera and kitchen facilities"
- The Shipyard

The ship is of medium size and offers two primary services: Entertainment and kitchen. The theater portion is a fluff piece for entertainment and community engagement in addition to providing variation in settings for restaurant ships. This is not a "salvage ship" with a kitchen stuffed in the back next to a chem vend and a science room.

This is a dinner and a show ship and it offers an opportunity for players who like to specialize in both to engage in that role. It's well within even the hand wavy balance guidelines.

At the most I could see it receiving a redress to have the seating area differentiated from the movie theater experience.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[ErhardSteinhauer]

You know what? I'll redo this PR and make it a bit cleaner. And will not touch vending machines in updated version.

[ErhardSteinhauer]

Reworked the PR, should be good for testing

[ErhardSteinhauer]

Left the kitchen on that theatre shuttle untouched

[ErhardSteinhauer]

Right, so I bought every shuttle I changed. They spawned upon purchase without errors.