-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STC: Remote consoles for controlling Trade Outpost traffic #1732
STC: Remote consoles for controlling Trade Outpost traffic #1732
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Pushed a change to the maps - added a tiny broom closet STC office to the Trade Outpost for the STC and switched a few of the consoles in Frontier's bridge around (babby's first mapping work, please cut me a little slack). Remote and local consoles seem to work fine. Need to fix the intercoms on the consoles - remote shouldn't have one at all, may need to fiddle with reparenting. Might want to get the ship consoles also (selectively?) displaying docking labels. Edit: antag fax machine is a placeholder with an obvious, incorrect ID to be edited to a new Trade Station STC prototype when it exists. stc.remote.consoles.mp4 |
Save any linter errors or mapping critique, I think this is good to go. Haven't drafted any changes to space law for trade station docking, can line those up if this is deemed suitable. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…-station-14 into 2024-07-25-stc-trade-station
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…-station-14 into 2024-07-25-stc-trade-station
Map is once again fixed, this PR should be good to go. Still needs a minor rewrite of the rules around docking requirement in space law. |
Think this is fine. Computers now require STC access to work. Didn't add an STC door remote (it would control all internal airlocks, which seems odd, and I don't think fiddling with the DoorRemoteSystem is a huge win in terms of gameplay). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didnt test in game yet but seen it working in stream.
STC gaming. |
Not happy about the SR door change. |
The one to the SR room? |
Wouldn't have done it if you'd have voiced your opinion in bug reports for it. Also, wasn't done in this PR. |
About the PR
Adds remote versions of the shuttle console to view a particular station. Increases the radar range for the STC's monitoring consoles to 350 metres.
Adds a Frontier-centric version of the DroneConsole component that matches a matching console with a DroneConsoleTarget component that match by key. This should allow for a sector-wide radar control room if such a thing were desirable.
The existing DroneConsole system isn't great - it requires changes to individual grids, and matches with the first console on that grid, rather than with a particular console.
Need to swap out sprites to better match (or have unique versions for each station to help visually disambiguate), should get navigation beacons showing on the map screen (which dock is dock 4A?)
Changes to the STC control will need matching adjustments to rules, Space Law, and the Guidebook, and an announcement to the player base (this proposes that the STC now monitors traffic around the Trade Outpost and that players must request docking if the STC is on-duty) - this also brings back the possibility for docking extensions and control at the Trade Outpost.
Why / Balance
With cargo moved off of Frontier station, and with traffic being diminished, this should give the STC more to do, should help . Also, the DroneComponent is neat and we don't use it at all - but we could.
How to test
Media
Changes to the Frontier Outpost bridge. Two radar consoles are on the desk, the comms console has been moved, and there are a fourth row of desks with an alerts console (pointless, but thought it made more sense than an empty desk space) and the wireless camera monitor.
The new Trade Outpost STC office. A hole in the wall intended as a mobile base, close to the center of the POI for radar coverage.
Showing the new radar consoles in use.
stc.remote.consoles.mp4
Breaking changes
Changelog
🆑