Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STC: Remote consoles for controlling Trade Outpost traffic #1732

Merged

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Jul 25, 2024

About the PR

Adds remote versions of the shuttle console to view a particular station. Increases the radar range for the STC's monitoring consoles to 350 metres.

Adds a Frontier-centric version of the DroneConsole component that matches a matching console with a DroneConsoleTarget component that match by key. This should allow for a sector-wide radar control room if such a thing were desirable.

The existing DroneConsole system isn't great - it requires changes to individual grids, and matches with the first console on that grid, rather than with a particular console.

Need to swap out sprites to better match (or have unique versions for each station to help visually disambiguate), should get navigation beacons showing on the map screen (which dock is dock 4A?)

Changes to the STC control will need matching adjustments to rules, Space Law, and the Guidebook, and an announcement to the player base (this proposes that the STC now monitors traffic around the Trade Outpost and that players must request docking if the STC is on-duty) - this also brings back the possibility for docking extensions and control at the Trade Outpost.

Why / Balance

With cargo moved off of Frontier station, and with traffic being diminished, this should give the STC more to do, should help . Also, the DroneComponent is neat and we don't use it at all - but we could.

How to test

  1. Spawn on Frontier Outpost, visit the bridge.
  2. Check the radar consoles on the STC's desk. They should be properly labelled, and only the local one should have a working intercom.
  3. Warp to the Trade Depot. You shouldn't teleport into a fax machine.
  4. Orient the map to Trade Depot's North and walk to the west. You'll end up at the STC's office.
  5. Check the radar consoles on the STC's desk. They should be properly labelled, and only the local one should have a working intercom.
  6. Check the fax machine, it should be labelled as "Trade Outpost STC" and function as a fax machine.
  7. Purchase a ship, the console should work properly.

Media

Changes to the Frontier Outpost bridge. Two radar consoles are on the desk, the comms console has been moved, and there are a fourth row of desks with an alerts console (pointless, but thought it made more sense than an empty desk space) and the wireless camera monitor.
frontier outpost STC revisions

The new Trade Outpost STC office. A hole in the wall intended as a mobile base, close to the center of the POI for radar coverage.
trade_station_stc

Showing the new radar consoles in use.

stc.remote.consoles.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: An extra radar has been added to the Frontier Outpost bridge to monitor Trade Outpost traffic.
  • add: The STC now has an off-base office in the Trade Outpost near the gravity generator.
  • fix: The SR's main office door is now accessible by the STC.

@github-actions github-actions bot added C# Map-Outpost Map - Outpost labels Jul 25, 2024
@whatston3 whatston3 added the Status: Awaiting Changes This PR has changes that need to be made before merging label Aug 9, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Aug 24, 2024
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Aug 24, 2024
@github-actions github-actions bot added the Map-POI Map - POI label Aug 27, 2024
@whatston3
Copy link
Contributor Author

whatston3 commented Aug 27, 2024

Pushed a change to the maps - added a tiny broom closet STC office to the Trade Outpost for the STC and switched a few of the consoles in Frontier's bridge around (babby's first mapping work, please cut me a little slack).

Remote and local consoles seem to work fine. Need to fix the intercoms on the consoles - remote shouldn't have one at all, may need to fiddle with reparenting. Might want to get the ship consoles also (selectively?) displaying docking labels.

Edit: antag fax machine is a placeholder with an obvious, incorrect ID to be edited to a new Trade Station STC prototype when it exists.

frontier outpost STC revisions
trade_station_stc

stc.remote.consoles.mp4

@whatston3 whatston3 marked this pull request as ready for review August 28, 2024 19:11
@whatston3
Copy link
Contributor Author

Save any linter errors or mapping critique, I think this is good to go. Haven't drafted any changes to space law for trade station docking, can line those up if this is deemed suitable.

@whatston3 whatston3 added Status: Needs Review This PR is awaiting reviews and removed Status: Awaiting Changes This PR has changes that need to be made before merging labels Aug 28, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Sep 3, 2024
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Sep 3, 2024
@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Sep 7, 2024
@whatston3
Copy link
Contributor Author

Map is once again fixed, this PR should be good to go. Still needs a minor rewrite of the rules around docking requirement in space law.

@dvir001 dvir001 self-requested a review September 17, 2024 20:23
@whatston3
Copy link
Contributor Author

Think this is fine. Computers now require STC access to work.

Didn't add an STC door remote (it would control all internal airlocks, which seems odd, and I don't think fiddling with the DoorRemoteSystem is a huge win in terms of gameplay).

Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt test in game yet but seen it working in stream.

@whatston3
Copy link
Contributor Author

STC gaming.

@whatston3 whatston3 merged commit 29424f8 into new-frontiers-14:master Sep 18, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Sep 18, 2024
@whatston3 whatston3 deleted the 2024-07-25-stc-trade-station branch September 21, 2024 01:14
@MagnusCrowe
Copy link
Contributor

Not happy about the SR door change.

@dvir001
Copy link
Contributor

dvir001 commented Sep 29, 2024

Not happy about the SR door change.

The one to the SR room?

@whatston3
Copy link
Contributor Author

whatston3 commented Sep 29, 2024

Not happy about the SR door change.

Wouldn't have done it if you'd have voiced your opinion in bug reports for it. Also, wasn't done in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Map-Outpost Map - Outpost Map-POI Map - POI Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants