Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS14 Sign #175

Merged
merged 2 commits into from
Sep 21, 2023
Merged

SS14 Sign #175

merged 2 commits into from
Sep 21, 2023

Conversation

potato1234x
Copy link
Contributor

About the PR

might as well do some minor changes check off some of the list

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑 Potato1234_x

  • tweak: The SS14 sign now says Frontier Station.

@Cheackraze
Copy link
Member

its good, dont get me wrong, but I think you could make it even better, give it some flair or something idk, you're pretty dang good with sprites I believe in you

@potato1234x
Copy link
Contributor Author

maybe make it gold kinda like the fulpstation sign? any specific ideas?

@Cheackraze
Copy link
Member

maybe some kind of object in the background, kind of like uh I think origin station has a custom one with a planet? maybe a space ship or something or maybe just like a better border or something idk, overall it might be better to try to keep it greyscale for color so that mappers can customize it

@potato1234x
Copy link
Contributor Author

just a concept but something like this?
image

@potato1234x
Copy link
Contributor Author

image
or in between the text?

@No-Dad-Not-The-Belt
Copy link
Contributor

image or in between the text?

+1 to this if the ship is angled at a 45 behind the text for the sign, but before the face-plate. Design is cool regardless.

@potato1234x
Copy link
Contributor Author

potato1234x commented Aug 10, 2023

or in between the text?

+1 to this if the ship is angled at a 45 behind the text for the sign, but before the face-plate. Design is cool regardless.

image
like this? (again just a prototype) or this?
image

@Cheackraze
Copy link
Member

or in between the text?

+1 to this if the ship is angled at a 45 behind the text for the sign, but before the face-plate. Design is cool regardless.

image like this? (again just a prototype) or this? image

coming along great, I like this a lot (with more polish of course) but I think that idea is great

@potato1234x
Copy link
Contributor Author

added some more shading to it, this is it in game
image

@potato1234x
Copy link
Contributor Author

no idea how to improve more, committed

@Cheackraze
Copy link
Member

no idea how to improve more, committed

looks good as is, always could be improved upon later too if you or anyone else gets inspired.

Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are replacing the old station plaques, I'm approving this but going to wait to merge till the next time I can go over the station map again. I recently did a hasty edit to add borg support but I want to better organize the mail area and make a few more significant station changes in the next 1-2 weeks. Just know its approved 100%, just may not get merged for a little bit yet, and if you feel inspired you're welcome to continue improving it in the meantime.

@Cheackraze Cheackraze merged commit 16c5381 into new-frontiers-14:master Sep 21, 2023
12 of 13 checks passed
FrontierATC added a commit that referenced this pull request Sep 21, 2023
@Cheackraze Cheackraze mentioned this pull request Oct 11, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants