Port playing cards from Estacao Pirata #1872
Conversation
|
RSI Diff Bot; head commit e6d5849 merging into edae074 Resources/Textures/EstacaoPirata/Objects/Misc/cards.rsi
|
There was a problem hiding this comment.
Pushed a set of changes onto whatston3:port-cards-suggestions, I think the changes improve interaction consistency.
Left-click on a deck or hand when holding a card, hand, or deck now always draws a card, and alt-click on a deck or hand always pushes the contents of your hand/card/deck onto a stack. Alt-click on a single card, even when holding a card, deck, or hand, will result in flipping it*. Picking a card to draw from a hand of two leaves the remaining card on the table, and a deck with two cards left turns into a single card when drawn from.
Did a revision pass over the fluent entries, everything seems good to my eyes. I would highly request giving that branch a test, it involved more changes than I'd like.
Reverted the access change to StorageSystem.FillStorage (as it was unused),
Nice little feature though, looking forward to seeing it in use.
- I looked into getting this to push the entire deck onto the card, but it was fiddly.
|
Really nice, ill give it a try. |
Port cards suggestions
|
should be good to review |
|
Are there any plans to update Casey's or Tinnia's to have decks of cards on their gambling tables round-start like the dice bags so they're readily available? Regardless, this PR might finally breath some life into Casey's and be good fun for creating player-driven RP scenarios, really looking forward to it! |
|
Did a real dumb over there, sorry. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Changes: Shaders
and removed
Merge Conflict
|
Mapped three deck boxes, two on Casey's, one on Tinnia's. Added animations for pretty much all card interactions. Didn't see any server errors when testing with invalid entity references. Cards will be sold for bugger all value, and the deck box has a price of 200 (sells from Good Clean Fun at 2k) to discourage spamming cards. Cards no longer stack infinitely, they stack to 212 (four complete decks). If you need more, play a different game, I suppose, or fiddle around with two decks and shuffle them between each other a few times. As far as I can see, it's good to go. |
|
Last set of changes, I swear. Click to draw and alt+click to push all cards if any card/hand/deck is in your active hand is always true, targeting a hand, card, or deck. Small quality of life changes, but good ones. One card hands/decks are still weird, but it's better than picking up two cards occasionally or having cards fall out of your pocket/backpack when swapping cards between hands.
|
|
Still wasn't happy with the oddities in the deck, I've tried a new tack: activation verbs. With these changes, clicking a deck without anything in hand now picks it up, like any other item. Pressing E on any card, hand, or deck in the world will now draw a single card from it (a bit odd for an activation verb, but better than oddball interaction via Z/LMB). The verb to draw should show up in right-click menus, so that's normal, and the pick up verb behaves for all card sets in its correct order, same with alternate verbs. Might rearrange shuffle and split functions for decks, and will need to give this another look with fresher eyes. |
|
Cards ho. |
About the PR
Ports playing cards and box of cards for everyone to enjoy from this PR rbertoche/space-station-14#104.
Why / Balance
Fun
How to test
Changelog
🆑 Leander