Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Arbitrator #1878

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

The Arbitrator #1878

wants to merge 32 commits into from

Conversation

VividPups
Copy link
Contributor

@VividPups VividPups commented Aug 17, 2024

About the PR

Called the Judge irl I made the Arbitrator. a revolver chamber in 45 50 and 60
sprites made by ra.Y

Why / Balance

it was requested by check a long time ago but with the current code couldn't make it. NOW we can this is a T3 shuttle and expedition

How to test

spawn it and pew pew

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame.

Changelog

🆑

  • add: The Arbitrator MulitChamber Revolver

Copy link
Contributor

github-actions bot commented Aug 17, 2024

RSI Diff Bot; head commit de2d699 merging into 247ab91
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Weapons/Guns/Ammunition/Boxes/magnum.rsi

State Old New Status
410caldisplay Added
454Casulldisplay Added

Resources/Textures/_NF/Objects/Weapons/Guns/Ammunition/Casings/410shells.rsi

State Old New Status
base-spent Added
base Added

Resources/Textures/_NF/Objects/Weapons/Guns/Revolvers/arbitrator.rsi

State Old New Status
bolt-open Added
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after de2d699

THE JUDGE
@VividPups VividPups marked this pull request as ready for review August 18, 2024 00:51
I think i did it right?
bruh
aaaaaa
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Aug 20, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've uploaded a set of suggestions to my repo, give them a review when you can, but I think it's reasonable:
https://github.com/VividPups/frontier-station-14/compare/Judge...whatston3:frontier-station-14:Judge-suggestions?expand=1

This should parent the BaseRevolver, then you can remove most of the components inside of the thing. I've added support for magnum speedloaders, since we have them, and the weapon case that you find them in comes with a full box of .60, a .45 speedloader, and the gun itself will be full of shotgun shells. Might be fun to have the minimum angle at 3 given the inevitable headspacing nightmares with some of those calibres.

Otherwise, as-is I think this is on par or better than the enforcer, given it's usable in one hand. Might suggest making it tier 4, and the Mateba might warrant a move with the fire rate of 3.

Please fix the sprite. It looks out of place with the other guns in the game (picture attached below), and there are half-transparent pixels near the optic and by the grip. For what it's worth, the in-hand sprite is also hard to read against the standard steel floor.
image

@VividPups
Copy link
Contributor Author

The sprite? That's the one you gave me. Also the sprites for the hands were done by a spriter in the discord (ra.Y)

Also the speedloader wasn't post to be supported for the reason that it will cause too much DPS. Imagine fighting a guy that used 60anti and then just speedloads 45. Or he rushes with shotgun shells and then speedloads 45

@whatston3
Copy link
Contributor

The sprite? That's the one you gave me. Also the sprites for the hands were done by a spriter in the discord (ra.Y)

Also the speedloader wasn't post to be supported for the reason that it will cause too much DPS. Imagine fighting a guy that used 60anti and then just speedloads 45. Or he rushes with shotgun shells and then speedloads 45

Just because I made something less awful doesn't make it good. Yes, it's not a vertically stretched monstrosity, but it still doesn't fit in with the rest of things.

The highest possible base damage per second with this is the shotgun assuming you can land the pellets, both the Mateba and N1984 have higher firing rates and capacity, a lot more DPS with .45, and now, carriable in one hand with this in the other as a 4 shot single handed no-wield shotgun. What's your point?

@arimah
Copy link
Contributor

arimah commented Aug 22, 2024

I'll be blunt, I do not like the idea of this gun supporting .60 anti-materiel rounds, even less coming with a box of them. .60 does 40 piercing, 30 structural and 35 stamina damage. Being able to fire off four such rounds in the space of two seconds does not sit right with me. There's a reason the only guns so far that can use those rounds are insanely slow. This gun strikes me as a powergamer's dream.

@Cheackraze
Copy link
Member

I can agree with it being chambered in only .45 and the shotgun shell, as that is still somewhat 'lore' accurate to the real pistol it is trying to emulate.

@ErhardSteinhauer
Copy link
Contributor

ErhardSteinhauer commented Aug 22, 2024

I wonder how this table ends up looking in the message.

weapon stats     ammo stats     armor 0.00 0.25 0.30 0.60 0.80
fire rate 2   .60 anti-materiel     .60 anti-materiel          
ammo cap 4   dmg 40   single shot 40.00 30.00 28.00 16.00 8.00
      .45     dps 80.00 60.00 56.00 32.00 16.00
      dmg 35   magdump 160.00 120.00 112.00 64.00 32.00
      shotgun shell     .45          
      # of pellets 6   single shot 35.00 26.25 24.50 14.00 7.00
      pellet dmg 10   dps 70.00 52.50 49.00 28.00 14.00
      total dmg 60   magdump 140.00 105.00 98.00 56.00 28.00
            shotgun shell          
            single shot 60.00 45.00 42.00 24.00 12.00
            dps 120.00 90.00 84.00 48.00 24.00
            magdump 240.00 180.00 168.00 96.00 48.00

I think that out of all suggested ammo types .45 and .60 are less problematic than shotgun shells: the latter can put in crit someone wearing an armor with 60% resistance to piercing damage if all pellets of all 4 shots land.

@VividPups
Copy link
Contributor Author

Before any changes, I would like to point out the chances of getting the weapon. compare to the other guns and spawners?
also, could the way it is obtained be considered different, like a mob boss? the tier of it be change to be higher? only allow it to be in certain expedition maps?

@VividPups
Copy link
Contributor Author

VividPups commented Aug 23, 2024

alright this is what i can try and do

I going to do what someone suggested and make the 410 shotgun shell. a 3 pellet shotgun shell with more spread and less damage. and change the 60 anti-material to ,454 casull

now IRL the Judge can Use 45 Colt, 410 and 454 casull

in this way 45 magnum is acting like 45 colt and 410 and 454 casull could match the gun IRL

image
454 casull is on the left, 44 mag is on the right

also I wont make all the different types of rounds. just the 2 basic rounds 410 and 454

@VividPups
Copy link
Contributor Author

its going to fail, the only thing it needs is the box rsi to work. then it should be done

@VividPups
Copy link
Contributor Author

The PR is ready for second review

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Sep 7, 2024
@VividPups
Copy link
Contributor Author

idk how to correct these errors

@VividPups
Copy link
Contributor Author

Changes were made as requested

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Sep 18, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Sep 18, 2024
request changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants