Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagabond Piping Fix #1976

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Conversation

PeccNeck
Copy link
Contributor

@PeccNeck PeccNeck commented Sep 10, 2024

About the PR

Updates the NT Vagabond to use directional fans, and to fix Vagabond piping issues (Discord).

Edit: Replaced the exterior waste air vent with a passive vent so it actually does what it's supposed to.

Why / Balance

Bug fix and moving to directional fans. Passive vent will also actually spew out waste gases into space now.

How to test

  • Spawn the NT Vagabond
  • Directional fans
  • Head towards the bridge
  • The scrubber and vent are no longer sitting on the floor
  • Go outside and look at the waste vent
  • It is no longer in under-pressure lockout by virtue of being an air vent in vacuum

Media

image
image
image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
🆑

  • fix: Fixed NT Vagabond's issues.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Sep 10, 2024
@dvir001 dvir001 self-requested a review September 20, 2024 15:38
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 20, 2024
@dvir001
Copy link
Contributor

dvir001 commented Sep 20, 2024

@PeccNeck Keep in mind I keep having to go back to editor to also replace the generators fuel to use new lockers, if you can submit the fix before it will help speed the PR's up

@dvir001 dvir001 merged commit a3e1ae0 into new-frontiers-14:master Sep 20, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants