Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost Roles: fix whitelist checks #1994

Merged

Conversation

whatston3
Copy link
Contributor

About the PR

Restores ghost role whitelist checks. Removed a few remaining "FRONTIER MERGE" comments with no relevance (commented code, unused imports).

Why / Balance

Error in previous upstream merge.

How to test

  1. Build the game, should build fine.
  2. Spawn with unwhitelisted account.
  3. /ghost. Check roles, emotional/station pets should be disabled.
  4. Comment out GhostRoleSystem.cs:598 (removes prototype, which the UI relies on to disable buttons).
  5. Build, spawn with unwhitelisted account.
  6. /ghost. Check roles, emotional/station pets should be enabled.
  7. Click all available whitelisted roles. Nothing should happen (server-side checks on Takeover, JoinRaffle).

Media

image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: Fixed ghost role whitelist requirement checks.

@github-actions github-actions bot added the C# label Sep 12, 2024
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks logical, didnt test in game yet.

@dvir001 dvir001 merged commit 4e32ff9 into new-frontiers-14:master Sep 14, 2024
11 checks passed
FrontierATC added a commit that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants