Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the M_EMP from affecting its own grid #1998

Merged

Conversation

whatston3
Copy link
Contributor

About the PR

Adds an immuneGrids argument to the EMPPulse function, prevents the M_EMP generator from affecting its own grid.

Why / Balance

Removing the last of the vessel EMP immunity. Complete pirate counterplay achieved?

We were already doing a grid check for the ProtectedGridComponent, this is a relatively cheap, completely additive inclusion.

How to test

  1. Spawn on NFSD Outpost.
  2. Purchase two Marauders (summon an extra ID and spesos if needed).
  3. Drive the first marauder over to the second.
  4. Activate the M_EMP generator.
  5. The Marauder you are on should not be affected. The other Marauder should be affected (respecting the 100 m limit from the generator), and the NFSD Outpost should not be affected.
  6. Lob an EMP grenade into your own Marauder. It should be affected by the pulse.

Media

This image shows two Marauders, one docked at the NFSD Outpost. The one on the left spawned an M_EMP pulse. The one on the right is affected (note the cyan sparks), and the NFSD Outpost is unaffected (note the lights are on).
image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: The M_EMP generator no longer affects the ship it is on.
  • remove: The Marauder is no longer EMP immune.

Copy link
Contributor

@MagnusCrowe MagnusCrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I noticed that it doesn't EMP the ship or any of the people or equipment on the ship.
It does affect things not on the grid.

So, it looks good to me.

I did the testing on a parcel to prove that the EMP immunity was indeed coming from the m_emp and not some other grid component. Also made a grid with a full sub nearby, it was also drained.

@MagnusCrowe MagnusCrowe merged commit ce6c74f into new-frontiers-14:master Sep 14, 2024
11 checks passed
FrontierATC added a commit that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants