Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcadia Ind. items are contraband, new trench and jumpsuit #1999

Merged

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Sep 13, 2024

About the PR

  • Classifies Arcadia Industries items as C3-contraband. Clothing has no FUCs value, vendomat costs 1 FUC.
  • Added Arcadia Ind. flak trenchcoat (recolored CSO labcoat from Baystation13.) and 'tactical' jumpsuit.

Why / Balance

Everything is contraband.

How to test

  1. Spawn and inspect arcadia ind. items.

Media

2024-9-13_07 25 26

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog
🆑 erhardsteinhauer

  • add: Added Arcadia Ind. flak trenchcoat and 'tactical' jumpsuit.
  • fix: Classified Arcadia Industries items as C3-contraband.

Copy link
Contributor

github-actions bot commented Sep 13, 2024

RSI Diff Bot; head commit 43719cc merging into fc6f3e0
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Clothing/OuterClothing/Coats/arcadia_trench.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon-open Added
icon Added
inhand-left Added
inhand-right Added
open-equipped-OUTERCLOTHING Added
open-inhand-left Added
open-inhand-right Added

Edit: diff updated after 43719cc

@ErhardSteinhauer ErhardSteinhauer added the Status: Needs Review This PR is awaiting reviews label Sep 13, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small set of rewrites, changed the backpacks to NoValue for consistency. Looks fine by me, works alright. Happy with this.

@whatston3 whatston3 merged commit 56d811e into new-frontiers-14:master Sep 16, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants