Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo and NSFD PDAs now include price or contraband appraisal functionality. These and a few medical-descended PDAs also now have more complete descriptions. #2004

Closed

Conversation

chrome-cirrus
Copy link

About the PR

This PR grabs some low hanging fruit in terms of adding to PDA functionality to give people more choices in their loadouts, and adds to descriptions of a few existing PDAs to make it clear they have extra functions. Specifically, it adds price gun functionality to cargo-related PDAs, and contraband appraisal functionality to NSFD/security related PDAs. It also adds a hint about health analyzer functionality to a few medical PDA descendants that didn't have that.

Why / Balance

Right now with very few exceptions a medical PDA is the obvious best choice for loadouts, and most of the alternatives have little to no additional functionality.

How to test

Spawn each PDA on the sandbox map, check its description, and verify each does what it should as far as as extended functionality.

Media

test1
test2

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Minor conflicts with upstream PDA definitions, noted with '# Frontier' comments.

Changelog
🆑

  • tweak: Added appraisal functionality to cargo and NSFD PDAs. Updated descriptions of a few medical PDAs to indicate inclusion of a health analyzer.

…n on these + a few medical PDA descendants for clarity
@dvir001
Copy link
Contributor

dvir001 commented Sep 13, 2024

This need to be a program, we want to avoid adding more hardcoded addon into PDA

@dvir001 dvir001 closed this Sep 13, 2024
@chrome-cirrus
Copy link
Author

Got it, thanks for the quick feedback!

@dvir001
Copy link
Contributor

dvir001 commented Sep 16, 2024

@chrome-cirrus space-wizards/space-station-14#32194 You want it to be like this PR on the code level.

@chrome-cirrus
Copy link
Author

@chrome-cirrus space-wizards/space-station-14#32194 You want it to be like this PR on the code level.

Perfect, I've got something right along those lines cooking in a new branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants