Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mech Blacklist #2007

Merged
merged 4 commits into from
Sep 14, 2024
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Sep 14, 2024

About the PR

Fixed 2 issues with mech pickup code

Added general blacklist support for mechs pickup.

Anything that on a chair will now be removed when the mech is picking up the object (Eg, hoverbike)
Mech cannot pickup another mech, seems logical

Why / Balance

Bug fixing.

How to test

Spawn a mech with pickup arms
Move mchands on hoverbike
Pickup the hoverbike
Mchands fall over in shame.

Media

N/A

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A

Changelog
🆑

  • tweak: When an item is picked up by a mech, anything buckled onto it is unbuckled first.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 14, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Good, nice change.

@whatston3
Copy link
Contributor

Works well enough, unbuckle admin log's a bit odd. Merging.

@whatston3 whatston3 merged commit 8d748d0 into new-frontiers-14:master Sep 14, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants