Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rodentia Code #2009

Merged
merged 13 commits into from
Sep 30, 2024
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Sep 14, 2024

About the PR

Mirror DeltaV-Station/Delta-v#1511

adds Rodentia code, a new species of anthropomorphic rodents (with some non-rodent-but-still-adjacent marking options).
But not as a lobby race, exists for the code of it and cannot be played as.

Media

DeltaV-Station/Delta-v#1511

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

DeltaV-Station/Delta-v#1511

Changelog
🆑

  • add: Made changes to goblins, use the guidebook for more info.
  • tweak: Mobs that are capable of rummaging (such as the Goblins species) can do so every five minutes. They will find trash in trash bins instead of entire wheels of cheese.

@dvir001 dvir001 changed the title 2024 09 14 ratatouille Rodentia Species Sep 14, 2024
@github-actions github-actions bot added Docs Improvements or additions to documentation Sprites YML C# FTL labels Sep 14, 2024
Copy link
Contributor

github-actions bot commented Sep 14, 2024

RSI Diff Bot; head commit 3011ca9 merging into 0aa6271
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Effects/creampie.rsi

State Old New Status
creampie_rodentia Added

Resources/Textures/DeltaV/Effects/speech.rsi

State Old New Status
rodentia0 Added
rodentia1 Added
rodentia2 Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/body_markings.rsi

State Old New Status
countershade Added
countershade_f Added
countershade_lleg Added
countershade_rleg Added
fawn Added
hooded Added
hooded_f Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/cheek_markings.rsi

State Old New Status
cheeks Added
cheeks_overlay Added
fluff Added
fluff_alt Added
fluff_alt_overlay Added
fluff_overlay Added
whiskers Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/ear_markings.rsi

State Old New Status
bat Added
bat_large Added
hamster Added
hamster_overlay Added
long Added
long_overlay Added
mouse Added
mouse_large Added
mouse_large_overlay Added
mouse_overlay Added
none Added
pointy Added
rabbit Added
rabbit_overlay Added
small Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/head_markings.rsi

State Old New Status
blaze Added
round Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/snout_markings.rsi

State Old New Status
bat Added
bat_nose Added
bat_overlay Added
flat Added
flat_nose Added
flat_overlay Added
round Added
round_nose Added
round_overlay Added

Resources/Textures/DeltaV/Mobs/Customization/Rodentia/tail_markings.rsi

State Old New Status
beaver Added
hamster Added
long Added
long_overlay Added
long_tip Added
mouse Added
rabbit Added
rabbit_overlay Added
short Added
squirrel Added
squirrel_overlay Added

Resources/Textures/DeltaV/Mobs/Species/Rodentia/parts.rsi

State Old New Status
full Added
head_f Added
head_m Added
l_arm Added
l_foot Added
l_hand Added
l_leg Added
r_arm Added
r_foot Added
r_hand Added
r_leg Added
torso_f Added
torso_m Added

Edit: diff updated after 3011ca9

@Cerebral-Error
Copy link

I'll be real, I think that Frontier has more than enough player species already, and if we were to add others, I'd personally prefer more alien-style races as opposed to another flavor of anthropomorphic animal.

@Tych0theSynth
Copy link
Contributor

I don't want to be too harsh, but also I do.
These are horrible. They look like people wearing budget fursuits.
I'm a furry, but even I don't feel like the game needs more anthro animal species. Something truly new would be far more interesting.

@arimah
Copy link
Contributor

arimah commented Sep 14, 2024

I agree with what Tych0 wrote. I don't think these are a good fit for Frontier and I would much rather have something unique and alien.

@dustylens
Copy link
Contributor

I believe that Bing's suggestion of creating a master species for spliced (thank you Magnus) Earth derived genomes with appropriate customization options is preferable to continuing to increase our portfolio of imported anthro species.

@Cheackraze
Copy link
Member

Yea thats where I'm at as well. We should just really merge then all into a "genetic anomaly" race. Vulp, felinid, rodent, and maybe even harpy rolled up into one, with that species having the option of adopting canine/felinid/rodent/avian traits whichever fits their specific morphotype

@dvir001 dvir001 mentioned this pull request Sep 14, 2024
2 tasks
@PeccNeck
Copy link
Contributor

I don't feel like here is the place for my input on a species merger, but I do like the idea of bnuuy. With that said, I do agree with Tych0 about:

These are horrible. They look like people wearing budget fursuits.

Felinids are your stereotypical catpeople and I'd say even Vulps aren't quite "budget fursuit" levels of spriting; these guys just feel off to me.

@dvir001
Copy link
Contributor Author

dvir001 commented Sep 16, 2024

Im thinking about keeping this race in the game but making it a NoSpawn and omitted from use for the sake of the added code factions.
Probably going to add the sneak and trash code to goblins in this case.

@Tych0theSynth
Copy link
Contributor

Tych0theSynth commented Sep 16, 2024

Would the trash code now allow for people to spam construct disposals units to farm them for stuff? I think that's a really bad idea.

@dvir001
Copy link
Contributor Author

dvir001 commented Sep 16, 2024

Would the trash code now allow for people to spam construct disposals units to farm them for stuff? I think that's a really bad idea.

Timer based on the player, not the entity, spawn 1 trash per activate.

@dvir001
Copy link
Contributor Author

dvir001 commented Sep 20, 2024

Would the trash code now allow for people to spam construct disposals units to farm them for stuff? I think that's a really bad idea.

Fixed this general issue with a goob fix

@dvir001 dvir001 changed the title Rodentia Species Rodentia Code Sep 20, 2024
@dvir001
Copy link
Contributor Author

dvir001 commented Sep 20, 2024

This PR is now about goblins changes using the Rodentia code

Rodentia are dormant in the code so we can use the assets.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 20, 2024
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno about C# part, but the rest looks fine (after things were commented out)

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Sep 29, 2024
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Sep 29, 2024
@dvir001
Copy link
Contributor Author

dvir001 commented Sep 30, 2024

Going to merge the code in a day if no one has issues with it, the Rodentia race is disabled as of now so we can use the assets later, also forks of frontier can enable it back if they want.

@dustylens
Copy link
Contributor

The rummaging through trash change seems like a lot of squeeze for not much juice. It's a funny rp meme but in truth I feel that Goblins are pretty stacked for funny rp memes. If there is trash there is trash. If there is not trash there is not trash.

However the only piece attached to that PR that I am wary of is hiding under tables. While I recognize that it's not explicitly mentioned as what is being added in this PR I am wary of it getting its foot in the door. From what I spotted over on delta it enabled some problematic behavior such as skipping past windoors and it seems like a pain to deal with.

@dvir001
Copy link
Contributor Author

dvir001 commented Sep 30, 2024

The rummaging through trash change seems like a lot of squeeze for not much juice. It's a funny rp meme but in truth I feel that Goblins are pretty stacked for funny rp memes. If there is trash there is trash. If there is not trash there is not trash.

However the only piece attached to that PR that I am wary of is hiding under tables. While I recognize that it's not explicitly mentioned as what is being added in this PR I am wary of it getting its foot in the door. From what I spotted over on delta it enabled some problematic behavior such as skipping past windoors and it seems like a pain to deal with.

Hiding under tables isn't used or added to any race here.

@dustylens
Copy link
Contributor

Understood. Just planting the flag of my one big concern for the Delta side PR. Other than the fursuits and issues with tiny creatures/mouse traps in general.

Everything else seems innocent enough. I'm sure a problematic issue could be raised with any of them. My brain tells me that it might be interesting/superior to have goblins spawn items from a specific table rather than generic trash. Items and tokens that are clearly extremely important to goblin culture. Bottlecap necklace and so on.

Just a thought.

@whatston3
Copy link
Contributor

Small set of suggestions up here: https://github.com/dvir001/frontier-station-14/compare/2024-09-14-Ratatouille...whatston3:frontier-station-14:2024-09-14-Ratatouille-suggestions?expand=1

I've added a cooldown to the rummager themselves (currently 30s vs. the trash can's 5 minutes) - should still make sense to rummage around in a few trash cans for peak dumpster dive RP, though you can't spam the same one over and over.

Also touched up the goblin guidebook entry.

Seems fine overall. Triggering mousetraps is pretty funny.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSI job passing at whatston3#6

Tried getting a rodent character through profile import trickery, didn't work.

Spawner still exists for admemes, seems fine. I've integrated the suggested changes, seems fine to me - please revert if you think otherwise (and sorry if so), but these changes seem alright to me.

@dvir001
Copy link
Contributor Author

dvir001 commented Sep 30, 2024

Small set of suggestions up here: https://github.com/dvir001/frontier-station-14/compare/2024-09-14-Ratatouille...whatston3:frontier-station-14:2024-09-14-Ratatouille-suggestions?expand=1

I've added a cooldown to the rummager themselves (currently 30s vs. the trash can's 5 minutes) - should still make sense to rummage around in a few trash cans for peak dumpster dive RP, though you can't spam the same one over and over.

Also touched up the goblin guidebook entry.

Seems fine overall. Triggering mousetraps is pretty funny.

Merggg it

@whatston3
Copy link
Contributor

Merggg it

Soon™.

@whatston3 whatston3 merged commit 95cbf55 into new-frontiers-14:master Sep 30, 2024
13 of 14 checks passed
FrontierATC added a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Docs Improvements or additions to documentation FTL Sprites Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants