-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rodentia Code #2009
Rodentia Code #2009
Conversation
RSI Diff Bot; head commit 3011ca9 merging into 0aa6271 Resources/Textures/DeltaV/Effects/speech.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/body_markings.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/cheek_markings.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/ear_markings.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/head_markings.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/snout_markings.rsi
Resources/Textures/DeltaV/Mobs/Customization/Rodentia/tail_markings.rsi
Resources/Textures/DeltaV/Mobs/Species/Rodentia/parts.rsi
|
I'll be real, I think that Frontier has more than enough player species already, and if we were to add others, I'd personally prefer more alien-style races as opposed to another flavor of anthropomorphic animal. |
I don't want to be too harsh, but also I do. |
I agree with what Tych0 wrote. I don't think these are a good fit for Frontier and I would much rather have something unique and alien. |
I believe that Bing's suggestion of creating a master species for spliced (thank you Magnus) Earth derived genomes with appropriate customization options is preferable to continuing to increase our portfolio of imported anthro species. |
Yea thats where I'm at as well. We should just really merge then all into a "genetic anomaly" race. Vulp, felinid, rodent, and maybe even harpy rolled up into one, with that species having the option of adopting canine/felinid/rodent/avian traits whichever fits their specific morphotype |
I don't feel like here is the place for my input on a species merger, but I do like the idea of bnuuy. With that said, I do agree with Tych0 about:
Felinids are your stereotypical catpeople and I'd say even Vulps aren't quite "budget fursuit" levels of spriting; these guys just feel off to me. |
Im thinking about keeping this race in the game but making it a NoSpawn and omitted from use for the sake of the added code factions. |
Would the trash code now allow for people to spam construct disposals units to farm them for stuff? I think that's a really bad idea. |
Timer based on the player, not the entity, spawn 1 trash per activate. |
Fixed this general issue with a goob fix |
This PR is now about goblins changes using the Rodentia code Rodentia are dormant in the code so we can use the assets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dunno about C# part, but the rest looks fine (after things were commented out)
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Going to merge the code in a day if no one has issues with it, the Rodentia race is disabled as of now so we can use the assets later, also forks of frontier can enable it back if they want. |
The rummaging through trash change seems like a lot of squeeze for not much juice. It's a funny rp meme but in truth I feel that Goblins are pretty stacked for funny rp memes. If there is trash there is trash. If there is not trash there is not trash. However the only piece attached to that PR that I am wary of is hiding under tables. While I recognize that it's not explicitly mentioned as what is being added in this PR I am wary of it getting its foot in the door. From what I spotted over on delta it enabled some problematic behavior such as skipping past windoors and it seems like a pain to deal with. |
Hiding under tables isn't used or added to any race here. |
Understood. Just planting the flag of my one big concern for the Delta side PR. Other than the fursuits and issues with tiny creatures/mouse traps in general. Everything else seems innocent enough. I'm sure a problematic issue could be raised with any of them. My brain tells me that it might be interesting/superior to have goblins spawn items from a specific table rather than generic trash. Items and tokens that are clearly extremely important to goblin culture. Bottlecap necklace and so on. Just a thought. |
Small set of suggestions up here: https://github.com/dvir001/frontier-station-14/compare/2024-09-14-Ratatouille...whatston3:frontier-station-14:2024-09-14-Ratatouille-suggestions?expand=1 I've added a cooldown to the rummager themselves (currently 30s vs. the trash can's 5 minutes) - should still make sense to rummage around in a few trash cans for peak dumpster dive RP, though you can't spam the same one over and over. Also touched up the goblin guidebook entry. Seems fine overall. Triggering mousetraps is pretty funny. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSI job passing at whatston3#6
Tried getting a rodent character through profile import trickery, didn't work.
Spawner still exists for admemes, seems fine. I've integrated the suggested changes, seems fine to me - please revert if you think otherwise (and sorry if so), but these changes seem alright to me.
Merggg it |
Soon™. |
About the PR
Mirror DeltaV-Station/Delta-v#1511
adds Rodentia code, a new species of anthropomorphic rodents (with some non-rodent-but-still-adjacent marking options).
But not as a lobby race, exists for the code of it and cannot be played as.
Media
DeltaV-Station/Delta-v#1511
Requirements
Breaking changes
DeltaV-Station/Delta-v#1511
Changelog
🆑