Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bluespace Events #2011

Merged
merged 6 commits into from
Sep 14, 2024
Merged

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Sep 14, 2024

About the PR

Fixes bluespace events, puts them on a separate timer from other in-game events, to ensure events are decently spaced apart.

Removes rewards for most grid values for bluespace events, sets the cache and vault events' rewards to 1 (from 3.3 and 0.7).

Moves a lot of maxOccurrences to reoccurrenceDelay (more suitable for longer shifts, e.g. on Hypatia).

Why / Balance

I goofed. The ability to have multiple schedulers should result in more predictable, less chaotic rounds, or at least, more stability/flexibility in scheduling events if changes are needed.

How to test

  1. Set the minimum/maximum time on the BluespaceEventScheduler to very small values, remove earliestStart and minimumPlayers.
  2. Spawn, wait about 2 minutes.
  3. Attention. Attention. Boo-weeeeep. All events should run.

Media

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: Bluespace events should now spawn again, and are scheduled separately from other events.
  • tweak: False alarms are more rare, NFSD/Frontier bank accounts are rewarded less for event completion.
  • remove: The CentDrobe has been removed from the Vault bluespace event.

@github-actions github-actions bot added Map-Bluespace Map - Bluespace Event No C# labels Sep 14, 2024
@dvir001 dvir001 merged commit e5eddc6 into new-frontiers-14:master Sep 14, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Bluespace Map - Bluespace Event No C#
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants