Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pen signing: Undupe messages, sound #2015

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Pen signing: Undupe messages, sound #2015

merged 1 commit into from
Sep 17, 2024

Conversation

whatston3
Copy link
Contributor

About the PR

Gets the pen to display "You sign the paper" once, and play the sound once, when signing a piece of paper.

Why / Balance

Annoying, buggy, inconsistent with stamp.

How to test

  1. Sign paper. Message should appear once, sound should play once.
  2. Bonus points: connect with another client. Sign on first client. On the second client, message should appear once, sound should play once.

Media

2024-09-15.10-56-45.mp4

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: Signing a piece of paper no longer duplicates audio and popup messages.

@github-actions github-actions bot added the C# label Sep 15, 2024
ErhardSteinhauer
ErhardSteinhauer approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described

@whatston3 whatston3 merged commit 3b254c2 into new-frontiers-14:master Sep 17, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Sep 17, 2024
@FrontierATC
Automatic Changelog (#2015)
2e28199
@whatston3 whatston3 deleted the 2024-09-15-pen-multisigning branch September 21, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErhardSteinhauer ErhardSteinhauer ErhardSteinhauer approved these changes

Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whatston3 @ErhardSteinhauer