Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fancy chairs #2031

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

Ghost-Prince
Copy link
Contributor

About the PR

Added fancy chairs to match the existing fancy tables.

Why / Balance

Fancy chairs to match the fancy tables because the wooden chair wasn't fancy enough.

How to test

Can be crafted by adding coloured carpet to wooden chair, similar to how carpet can be added to wooden table.

Media

image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

I hope not.

Changelog

🆑

  • add: Added Fancy chairs! Use carpet to put cover on wooden chair.

@arimah arimah changed the title Fancy chairs 20210912 Add fancy chairs Sep 19, 2024
Copy link
Contributor

github-actions bot commented Sep 19, 2024

RSI Diff Bot; head commit 16da911 merging into 213355e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Furniture/chairs.rsi

State Old New Status
wooden_fancy-black Added
wooden_fancy-blue Added
wooden_fancy-cyan Added
wooden_fancy-green Added
wooden_fancy-orange Added
wooden_fancy-pink Added
wooden_fancy-purple Added
wooden_fancy-red Added
wooden_fancy-white Added

Edit: diff updated after 16da911

@VividPups

This comment was marked as off-topic.

@dvir001 dvir001 self-requested a review September 20, 2024 09:15
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 20, 2024
@dvir001
Copy link
Contributor

dvir001 commented Sep 20, 2024

I was about to say who the fuck crowbar a cloth from a chair but this is same as upstream tables so Ill let it be for now.

@dvir001 dvir001 merged commit dfd0ff8 into new-frontiers-14:master Sep 20, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Sep 20, 2024
@Ghost-Prince Ghost-Prince deleted the Fancy-Chairs-20210912 branch September 23, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants