Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMC hardsuit #2037

Closed
wants to merge 22 commits into from
Closed

PMC hardsuit #2037

wants to merge 22 commits into from

Conversation

starch70
Copy link

@starch70 starch70 commented Sep 21, 2024

About the PR

i made a reskin of the HoS hardsuit with identical stats to merc hardsuit
also made the suit storage and wall suit storage for it of course
currently doesnt actually spawn anywhere, because editing random peoples shuttles is weird, and i dont really know how to edit exped/salvage/whatever else loot tables.

ignore the random commits related to my shuttle i submitted i dont know why they're there

Why / Balance

i like HoS hardsuit look but i cant map it because it will confuse new players or something. also i personally think the current merc and private security hardsuits are kinda visually unappealing to me atleast

How to test

search PMC in entity spawner, every result will be my hardsuit.

Media

hardsuit + oxygen/nitrogen tank on human, vulpakin, and vox (to show the different race specific helmet sprites working)
image
image
image
image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

🆑

  • add: PMC hardsuit, a recolored HoS hardsuit with identical stats as merc/private sec hardsuit. Currently only way to get is via its suit storage lockers, which don't spawn anywhere right now because I do not want to edit peoples shuttles.

@github-actions github-actions bot added Docs Improvements or additions to documentation Map-Shuttle Map - Shuttle No C# Sprites FTL labels Sep 21, 2024
Copy link
Contributor

github-actions bot commented Sep 21, 2024

RSI Diff Bot; head commit 1ef406a merging into c502739
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Clothing/Head/Hardsuits/pmc.rsi

State Old New Status
icon-flash Added
icon Added
off-equipped-HELMET-vox Added
off-equipped-HELMET-vulpkanin Added
off-equipped-HELMET Added
on-equipped-HELMET-vox Added
on-equipped-HELMET-vulpkanin Added
on-equipped-HELMET Added

Resources/Textures/_NF/Clothing/OuterClothing/Hardsuits/pmc.rsi

State Old New Status
equipped-OUTERCLOTHING-vox Added
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 1ef406a

@starch70
Copy link
Author

oh god my shuttles changes are in there for some reason please someone remove those

@github-actions github-actions bot added YML and removed Docs Improvements or additions to documentation Map-Shuttle Map - Shuttle FTL labels Sep 21, 2024
…curity and mercenary hardsuits (exped loot, combat hardsuit arsenal research thing, lathes)
@github-actions github-actions bot added Docs Improvements or additions to documentation Map-Shuttle Map - Shuttle FTL and removed YML labels Sep 21, 2024
@starch70
Copy link
Author

i added my hardsuit to the loot tables and lathe places i found merc hardsuits in and my shuttle is trying to invade me again help

@dvir001
Copy link
Contributor

dvir001 commented Sep 21, 2024

Please remove unrelated files or reopen the PR without the files.

RSI Lower case file names except where needed, fix please

@github-actions github-actions bot removed Docs Improvements or additions to documentation Map-Shuttle Map - Shuttle FTL labels Sep 21, 2024
@github-actions github-actions bot added the YML label Sep 21, 2024
@starch70
Copy link
Author

ok i fixed my shuttle PR trying to invade this PR and i changed the .rsi folders to be lowercase instead of uppercase

changed parent for PMC hardsuit crates to be normal merc crates because i forgot there is no PMC crate when i edited it
@starch70
Copy link
Author

just rememebered that there is no fucking PMC crate so i changed the pmc hardsuit crates to have merc crate parents instead of the non-existant PMC crate

@starch70
Copy link
Author

should i change the color of the green parts on the helmt? if so what do i change it too?

changes description, changes light color
edits clothing speed and armor of PMC hardsuit to have armor values like 5% higher than the merc hardsuit, with the tradeoff of 35% rad protection instead of 40% rad protection, and higher mobility penalties

(i did this because the HoS hardsuit actually is quite bulky compared to it and i just realized that)
changes plasteel cost of PMC hardsuit from 2000 to 2500, and adds 250 steel to cost (done because HoS hardsuit sprite is kinda bulkier than merc one, and i have increased armor values and lowered movement speed to make it more of a heavier option)
@starch70
Copy link
Author

starch70 commented Oct 2, 2024

i have just realized that the HoS hardsuit sprite (in wizden atleast) is kinda bulkier than the merc hardsuit, so i edited values to be a bit higher for armor protection, but slightly lowered rad protection and it makes you a bit slower than the merc hardsuit now. also changed the helmet light to be less-shit, and increased mat cost by 250 steel and 500 plasteel

@dvir001
Copy link
Contributor

dvir001 commented Oct 2, 2024

Please do not power creep armor
Keep it the same as the other one its based on by parenting.

I'm still waiting for a project art decision if we even want a recolor of the ugly HOS armor in the game.

@starch70
Copy link
Author

starch70 commented Oct 2, 2024

ok, i will revert the stats

reverted it having better light range
reverted it having better armor and worse movement
reverted description because i forgot
reverted lathe recipe change
@starch70
Copy link
Author

starch70 commented Oct 2, 2024

i have only now realized that the crate i made for this doesnt actually exist for some reason and isnt even in the entity spawner im gonna try to fix this when i get home

@starch70
Copy link
Author

This shit sucks i cant bear the weight of this anymore im closing it and deleting the branch lol

@starch70 starch70 closed this Oct 23, 2024
@starch70 starch70 deleted the PMChardsuit branch October 23, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants