Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an item appraisal cartridge for PDAs #2045

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrome-cirrus
Copy link

@chrome-cirrus chrome-cirrus commented Sep 21, 2024

About the PR

Adds an item appraisal cartridge for PDAs. Supports left-click interaction to appraise items while the program is active, and keeps a rolling history of those results visible in the PDA interface. Right-click appraisal utility verb is available for cases like bags or deep fryers that the PDA would be placed into on left-click, but those results won't be stored in history due to implementation horrors (see comments in code). Cribs heavily from the Netprobe cartridge for UI.

Why / Balance

Right now with very few exceptions a medical PDA is the obvious best choice for loadouts, and most of the alternatives have little to no additional functionality. More choices that do something beyond just having a different sprite is fun.

How to test

Start up a local instance, spawn in an appraisal cartridge and whatever PDAs you think look coolest. Install the cartridge and exercise the program on the items in the sandbox zone, verify things function as expected.

Media

appapp1
appapp2

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

@dvir001
Copy link
Contributor

dvir001 commented Sep 21, 2024

Dont install the PDA app into any PDA
Were working on moving all PDA "programs" to a new loadout tab so people can get any pda with any program. (Health analyzer. music etc)

You can leave it not mapped into any PDA if you add the program and we can add it to new loadouts after.

@chrome-cirrus
Copy link
Author

Oh badass! I'll remove the PDA additions then.

@dvir001
Copy link
Contributor

dvir001 commented Sep 21, 2024

All new frontier code has to be under _NF also, not just yaml

@dvir001 dvir001 requested review from whatston3 and dvir001 and removed request for whatston3 September 21, 2024 21:54
@dvir001 dvir001 added the Status: Awaiting Changes This PR has changes that need to be made before merging label Sep 21, 2024
@github-actions github-actions bot added Status: Needs Review This PR is awaiting reviews Merge Conflict This PR has conflicts that prevent merging and removed Status: Awaiting Changes This PR has changes that need to be made before merging labels Sep 21, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Sep 22, 2024
@chrome-cirrus
Copy link
Author

Alright, removed the pre-installation in cargo/QM PDAs. Scooted the files around and updated namespace in a few places as needed. Did a component addition thing to make the utility verb on right-click work (still doesn't integrate with the PDA UI part, but that's a better experience than just not having it at all).

@chrome-cirrus
Copy link
Author

Tested this on 'regular' PDA variants, as well as on the medical one that still has hardcoded components for added function. It doesn't interfere with the medical one, but you will get both an appraisal and medical scan on someone when you left click them with a medical PDA while the appraisal program is active. Harmless enough, and will get fixed when the medical scanner stuff is itself moved into a cartridge.

@chrome-cirrus chrome-cirrus changed the title Add an item appraisal cartridge for PDAs. Install it by default in th… Add an item appraisal cartridge for PDAs Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants