-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an item appraisal cartridge for PDAs #2045
base: master
Are you sure you want to change the base?
Add an item appraisal cartridge for PDAs #2045
Conversation
Dont install the PDA app into any PDA You can leave it not mapped into any PDA if you add the program and we can add it to new loadouts after. |
Oh badass! I'll remove the PDA additions then. |
All new frontier code has to be under _NF also, not just yaml |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
0f4e760
to
9f5bb30
Compare
9f5bb30
to
fe2d03f
Compare
Alright, removed the pre-installation in cargo/QM PDAs. Scooted the files around and updated namespace in a few places as needed. Did a component addition thing to make the utility verb on right-click work (still doesn't integrate with the PDA UI part, but that's a better experience than just not having it at all). |
Tested this on 'regular' PDA variants, as well as on the medical one that still has hardcoded components for added function. It doesn't interfere with the medical one, but you will get both an appraisal and medical scan on someone when you left click them with a medical PDA while the appraisal program is active. Harmless enough, and will get fixed when the medical scanner stuff is itself moved into a cartridge. |
About the PR
Adds an item appraisal cartridge for PDAs. Supports left-click interaction to appraise items while the program is active, and keeps a rolling history of those results visible in the PDA interface. Right-click appraisal utility verb is available for cases like bags or deep fryers that the PDA would be placed into on left-click, but those results won't be stored in history due to implementation horrors (see comments in code). Cribs heavily from the Netprobe cartridge for UI.
Why / Balance
Right now with very few exceptions a medical PDA is the obvious best choice for loadouts, and most of the alternatives have little to no additional functionality. More choices that do something beyond just having a different sprite is fun.
How to test
Start up a local instance, spawn in an appraisal cartridge and whatever PDAs you think look coolest. Install the cartridge and exercise the program on the items in the sandbox zone, verify things function as expected.
Media
Requirements
Breaking changes
Changelog