Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds four new pear based meal recipes. #2047

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dustylens
Copy link
Contributor

About the PR

This PR adds four new pear meal recipes. A "tart", a savory and dessert poached recipe and a simple muffin.

Finally the noble pear has a home.

Why / Balance

There were 0 recipes for the pear. Seemed like the thing to do.

How to test

Prepare each of the meals. Should work a treat.

I would appreciate, as always, a critical eye on my sprites and the final recipes/values. This is an emerging skill for me and I recognize that there is certainly room for improvement.

Media

ss+(2024-09-21+at+06 42 20)

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None.

Changelog

🆑

  • add: Four new pear based meal recipes.

This PR adds four new pear meal recipes. A "tart", a savory and dessert poached recipe and a simple muffin.

Finally the noble pear has a home.
Copy link
Contributor

github-actions bot commented Sep 22, 2024

RSI Diff Bot; head commit 5e74a26 merging into d8a0027
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Consumable/Food/Baked/bread.rsi

State Old New Status
pearmuffin Added

Resources/Textures/_NF/Objects/Consumable/Food/Baked/pie.rsi

State Old New Status
inhand-left Added
inhand-right Added
pearandcheese Added
tin Added

Resources/Textures/_NF/Objects/Consumable/Food/bowl.rsi

State Old New Status
bellepear Added
poachedpear Added

Edit: diff updated after 5e74a26

@Tych0theSynth
Copy link
Contributor

Excited Loops and Alma noises

@HandsomeTheEgg
Copy link

HandsomeTheEgg commented Sep 22, 2024

a critical eye on my sprites and the final recipes/values.

Recipes looks fine to me and values .The sprites made me wanting to have some ice cream and cake , very good. The thing i noticed is like the MaxVol on some stuff is lower than what it contains (not sure if it really matters if it needs to be equal from the stuff thats inside) i also like that you left some room in the muffin/pie for adding condiments .

Maybe another suggestion would be -1 or -2 ChocolateBar on the bella pears,adding 1-2 oranges to recipe,and change the small orange above the cream in the sprite to a small lemon (just yellow colouring)since it uses one in the recipe, but it would also be fine how it currently is.

@dustylens
Copy link
Contributor Author

dustylens commented Sep 22, 2024

Thank you for the spot on the Bella pears maxVol. I dropped a chocolate bar from the recipe, one per pear is a bit much. For now I'm going to keep the fruit where they are. Distant rumblings has informed that there will be a new way of looking at how nutritional values and expectations are calculated in foods and when that day comes I'll almost certainly be revisiting quantities and types of ingredients. If that seems reasonable. Determining how much nutriment should be inherited, how much should be converted to flavorol, etc, are all fairly challenging considerations to make at the moment and have resulted in some pretty wobbly foods.

I want ice cream too now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants