-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barge Guidebook Entry #2048
Merged
Merged
Barge Guidebook Entry #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Docs
Improvements or additions to documentation
Map-Shuttle
Map - Shuttle
No C#
Sprites
YML
FTL
labels
Sep 22, 2024
dvir001
requested review from
whatston3,
ErhardSteinhauer,
arimah and
MagnusCrowe
September 22, 2024 09:35
No need for changelog |
Goodbye changelog. |
ErhardSteinhauer
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
whatston3
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSI validator passes here: whatston3#7
Will remember to squash next time. Sorry. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Docs
Improvements or additions to documentation
FTL
Map-Shuttle
Map - Shuttle
No C#
Sprites
Status: Needs Review
This PR is awaiting reviews
YML
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds guidebook entry and schematic for the Barge.
Why / Balance
Filling in some of the missing manual entries seemed decent enough for a first PR. Picked the Barge due to it not having an active maintainer listed (or at least doesn't seem to have been worked on recently). The Hauler is done as well pending a sprite, if this goes well I'll put that up for review too.
The preflight checklist is copied and adjusted from other solar-powered vessels; do double-check my work to see if the sidenotes are correct.
How to test
Media
Requirements
Breaking changes
If I say it won't, it will.