Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barge Guidebook Entry #2048

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Conversation

Mygnol
Copy link
Contributor

@Mygnol Mygnol commented Sep 22, 2024

About the PR

Adds guidebook entry and schematic for the Barge.

Why / Balance

Filling in some of the missing manual entries seemed decent enough for a first PR. Picked the Barge due to it not having an active maintainer listed (or at least doesn't seem to have been worked on recently). The Hauler is done as well pending a sprite, if this goes well I'll put that up for review too.

The preflight checklist is copied and adjusted from other solar-powered vessels; do double-check my work to see if the sidenotes are correct.

How to test

  • Go to shipyard
  • Find barge
  • Manual button now has accompanying entry

Media

image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

If I say it won't, it will.

@github-actions github-actions bot added Docs Improvements or additions to documentation Map-Shuttle Map - Shuttle No C# Sprites YML FTL labels Sep 22, 2024
Copy link
Contributor

github-actions bot commented Sep 22, 2024

RSI Diff Bot; head commit bf2a760 merging into 08cbef0
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Guidebook/shuttle_maps/128x96.rsi

State Old New Status
barge Added

Edit: diff updated after bf2a760

@Mygnol Mygnol marked this pull request as ready for review September 22, 2024 09:25
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 22, 2024
@dvir001
Copy link
Contributor

dvir001 commented Sep 22, 2024

No need for changelog

@Mygnol
Copy link
Contributor Author

Mygnol commented Sep 22, 2024

Goodbye changelog.

@Mygnol Mygnol mentioned this pull request Sep 29, 2024
2 tasks
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSI validator passes here: whatston3#7

@whatston3 whatston3 merged commit afb0237 into new-frontiers-14:master Sep 30, 2024
12 of 13 checks passed
@whatston3
Copy link
Contributor

Will remember to squash next time. Sorry.

@Mygnol Mygnol deleted the barge-guidebook branch October 1, 2024 15:50
@Mygnol Mygnol mentioned this pull request Oct 4, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Improvements or additions to documentation FTL Map-Shuttle Map - Shuttle No C# Sprites Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants