Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garden Directional Fan Update #2052

Merged

Conversation

dustylens
Copy link
Contributor

@dustylens dustylens commented Sep 22, 2024

About the PR

Tiny fans replaced with directional fans.
Generator replaced with ship type.
Added plasma fuel wall locker.
Updated atmos tanks for compliance.
Threw in a complimentary beaker.

Why / Balance

Compliance.

How to test

Check mixer.
Check power.
Check tiny fans.

Media

ss+(2024-09-22+at+02 37 12)

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Garden updated with directional fans and o2/n2 system.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Sep 22, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny fans look good, atmos seems sane, YAML looks fine - no issues encountered.

One odd thing - the air alarm near the entrance has no linked devices. Confirmed this is the same on the current head of master. Not your doing, but still odd, and worth note.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New air alarm seems good.

@MagnusCrowe MagnusCrowe merged commit e2c83e7 into new-frontiers-14:master Sep 23, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants